Re: [PATCH 03/30] brcmfmac: Split brcmf_sdiod_regrw_helper() up.
From: Arend van Spriel <arend.vanspriel@broadcom.com>
Date: 2017-08-30 19:00:03
On 22-08-17 13:25, Ian Molton wrote:
This large function is concealing a LOT of obscure logic about how the hardware functions. Time to split it up.
Again the tab. Guess it is your default ;-)
quoted hunk ↗ jump to hunk
This first patch splits the function into two pieces - read and write, doing away with the rw flag in the process. Signed-off-by: Ian Molton <redacted> Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com> --- .../wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 94 +++++++++++++++++----- 1 file changed, 73 insertions(+), 21 deletions(-)diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c index 2b441ce91d5f..1ee0f91b6c50 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c@@ -302,8 +302,8 @@ static int brcmf_sdiod_request_data(struct brcmf_sdio_dev *sdiodev, u8 fn, return ret; } -static int brcmf_sdiod_regrw_helper(struct brcmf_sdio_dev *sdiodev, u32 addr, - u8 regsz, void *data, bool write) +static int brcmf_sdiod_reg_write(struct brcmf_sdio_dev *sdiodev, u32 addr, + u8 regsz, void *data)
Thought I mentioned this before, but the indentation should be aligned to opening bracket.
{
u8 func;
s32 retry = 0;[...]
+ +static int brcmf_sdiod_reg_read(struct brcmf_sdio_dev *sdiodev, u32 addr, + u8 regsz, void *data)
dito here. Regards, Arend