Re: [PATCH 17/30] brcmfamc: remove unnecessary call to brcmf_sdiod_set_backplane_window()

On 23/08/17 11:09, Julian Calaby wrote:

I don't think I explained my point well.

The description of this patch implies that this method
brcmf_sdiod_ramrw(), now relies on the window being set elsewhere
before it's called.

I don't think it does.

I'm asking why we can't move the setting of the window inside this
function and remove any redundant calls to
brcmf_sdiod_set_backplane_window() outside of it.

We do call brcmf_sdiod_set_backplane_window() in this function. We just
dont need to call it a second time to restore the original window.

It may have been required in the past because the code relied on a value
not changing (swbadr) which was a poor assumption. In practice, the
current code does not provoke this potential bug, which I remove all
possibility of happening in patch 23/30

-Ian