Re: [PATCH v8 04/15] khugepaged: generalize alloc_charge_folio()
From: Baolin Wang <baolin.wang@linux.alibaba.com>
Date: 2025-07-08 06:19:27
Also in:
linux-doc, linux-mm, lkml
On 2025/7/2 13:57, Nico Pache wrote:
quoted hunk ↗ jump to hunk
From: Dev Jain <dev.jain@arm.com> Pass order to alloc_charge_folio() and update mTHP statistics. Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com> Co-developed-by: Nico Pache <npache@redhat.com> Signed-off-by: Nico Pache <npache@redhat.com> Signed-off-by: Dev Jain <dev.jain@arm.com> --- include/linux/huge_mm.h | 2 ++ mm/huge_memory.c | 4 ++++ mm/khugepaged.c | 17 +++++++++++------ 3 files changed, 17 insertions(+), 6 deletions(-)diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index 4d5bb67dc4ec..a6ea89fdaee6 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h@@ -125,6 +125,8 @@ enum mthp_stat_item { MTHP_STAT_ANON_FAULT_ALLOC, MTHP_STAT_ANON_FAULT_FALLBACK, MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE, + MTHP_STAT_COLLAPSE_ALLOC, + MTHP_STAT_COLLAPSE_ALLOC_FAILED, MTHP_STAT_ZSWPOUT, MTHP_STAT_SWPIN, MTHP_STAT_SWPIN_FALLBACK,diff --git a/mm/huge_memory.c b/mm/huge_memory.c index ce130225a8e5..69777a35e722 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c@@ -614,6 +614,8 @@ static struct kobj_attribute _name##_attr = __ATTR_RO(_name) DEFINE_MTHP_STAT_ATTR(anon_fault_alloc, MTHP_STAT_ANON_FAULT_ALLOC); DEFINE_MTHP_STAT_ATTR(anon_fault_fallback, MTHP_STAT_ANON_FAULT_FALLBACK); DEFINE_MTHP_STAT_ATTR(anon_fault_fallback_charge, MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE); +DEFINE_MTHP_STAT_ATTR(collapse_alloc, MTHP_STAT_COLLAPSE_ALLOC); +DEFINE_MTHP_STAT_ATTR(collapse_alloc_failed, MTHP_STAT_COLLAPSE_ALLOC_FAILED); DEFINE_MTHP_STAT_ATTR(zswpout, MTHP_STAT_ZSWPOUT); DEFINE_MTHP_STAT_ATTR(swpin, MTHP_STAT_SWPIN); DEFINE_MTHP_STAT_ATTR(swpin_fallback, MTHP_STAT_SWPIN_FALLBACK);@@ -679,6 +681,8 @@ static struct attribute *any_stats_attrs[] = { #endif &split_attr.attr, &split_failed_attr.attr, + &collapse_alloc_attr.attr, + &collapse_alloc_failed_attr.attr, NULL, };
Sorry, I forgot to mention that you should update the 'Documentation/admin-guide/mm/transhuge.rst' file for these new statistics.