Thread (61 messages) 61 messages, 4 authors, 2020-05-16

Re: [PATCH 00/17] spi: dw: Add generic DW DMA controller support

From: Serge Semin <hidden>
Date: 2020-05-13 11:04:14
Also in: linux-devicetree, linux-spi, lkml

On Wed, May 13, 2020 at 11:23:24AM +0100, Mark Brown wrote:
On Tue, May 12, 2020 at 11:07:33PM +0300, Serge Semin wrote:
quoted
On Fri, May 08, 2020 at 02:33:36PM +0100, Mark Brown wrote:
quoted
quoted
Please don't make new feature development dependent on conversion to the
new schema format, there's quite a backlog of reviews of schema
conversions so it can slow things down.  It's good to do the conversions
but please do them after adding any new stuff to the binding rather than
before.
quoted
So by saying this do you want me to revert an order of the first two patches
in the series, right? So the series would first add the DMA properties support
to the binding, then would convert the binding file to DT schema.
The conversion to YAML format should be the very last thing in the patch
series,
Hm, haven't heard about this requirement. Could you point me out to a doc or
some discussion concerning this for future reference? It's not a first DT
conversion patch I've submitted and non of them were addressed with such
request. I do understand that the order of DT concerning patches can be
important and agree to fix it by updating the original legacy binding first,
then perform a conversion. But placing the conversion in a tail of the series
just seems unnecessary. The patch can be dropped from any place of the series
if for some reason Rob would be late with review.

Personally I prefer placing all DT changes in the head of the series, so Rob
wouldn't need to search through the whole patchset looking for the DT-related
patches.

-Sergey
and as Andy says there's another patch in flight also doing this
conversion which you should coordinate with.
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help