Re: [PATCH RFC 60/67] MIPS: math-emu: cp1emu: Move the fpucondbit struct to a header
From: Sergei Shtylyov <hidden>
Date: 2014-12-19 12:10:32
On 12/18/2014 6:10 PM, Markos Chandras wrote:
The fpucondbit struct will be used later on by the MIPS R2 instruction
It's not *struct*.
emulator, so in order to access it, we need to move it to a header.
Signed-off-by: Markos Chandras <redacted> --- arch/mips/include/asm/fpu_emulator.h | 12 ++++++++++++ arch/mips/math-emu/cp1emu.c | 12 ------------ 2 files changed, 12 insertions(+), 12 deletions(-)
quoted hunk ↗ jump to hunk
diff --git a/arch/mips/include/asm/fpu_emulator.h b/arch/mips/include/asm/fpu_emulator.h index 3ee347713307..d7670bd80855 100644 --- a/arch/mips/include/asm/fpu_emulator.h +++ b/arch/mips/include/asm/fpu_emulator.h@@ -30,6 +30,18 @@ #include <asm/local.h> #include <asm/processor.h> +/* convert condition code register number to csr bit */ +static const unsigned int fpucondbit[8] = {
Why not *extern* declaration instead? We don't define data in the header
files.
+ FPU_CSR_COND0, + FPU_CSR_COND1, + FPU_CSR_COND2, + FPU_CSR_COND3, + FPU_CSR_COND4, + FPU_CSR_COND5, + FPU_CSR_COND6, + FPU_CSR_COND7 +}; +
[...] WBR, Sergei