Hi Andy,

On Tue, Jun 06, 2017 at 03:59:49PM +0300, Andy Shevchenko wrote:

On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani [off-list ref] wrote:

quoted

The TPS68470 device is an advanced power management
unit that powers a Compact Camera Module (CCM),
generates clocks for image sensors, drives a dual
LED for Flash and incorporates two LED drivers for
general purpose indicators.

This patch adds support for TPS68470 mfd device.

I dunno why you decide to send this out now, see my comments below.

quoted

+static int tps68470_chip_init(struct tps68470 *tps)
+{
+       unsigned int version;
+       int ret;

quoted

+       /* FIXME: configure these dynamically */

So, what prevents you to fix this?

Nothing I suppose. They're however not needed right now and can be
implemented later on if they're ever needed.

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk