Thread (283 messages) 283 messages, 37 authors, 2007-07-12

Re: Interface for the new fallocate() system call

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2007-03-29 18:37:03
Also in: linux-fsdevel, linux-xfs, lkml


On Thu, 29 Mar 2007, Jan Engelhardt wrote:
I have to disagree, since wrapping it into a struct and copying the struct
in kernelspace from userspace requires more code.
Not just more code, but more security issues too.

Passing system call arguments by value means that there are no subtle 
security issues - the value you use is the value you got. But once you 
pass-by-reference, you have to make damn sure that you do the proper user 
space accesses and verify the pointer correctly.

User-space (aka "user-supplied") pointers are just more dangerous. We 
obviously can't avoid them, but they need much more care than just a 
random value directly passed in a register.

		Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help