Re: [PATCH 04/12] dt-bindings: riscv: Add Allwinner D1 board compatibles
From: Heiko Stübner <heiko@sntech.de>
Date: 2022-08-16 10:35:10
Also in:
linux-riscv, linux-sunxi, lkml
Am Dienstag, 16. August 2022, 09:39:38 CEST schrieb Krzysztof Kozlowski:
On 15/08/2022 08:08, Samuel Holland wrote:quoted
Several SoMs and boards are available that feature the Allwinner D1 SoC. Document their compatible strings. Signed-off-by: Samuel Holland <samuel@sholland.org> --- .../devicetree/bindings/riscv/sunxi.yaml | 64 +++++++++++++++++++ 1 file changed, 64 insertions(+) create mode 100644 Documentation/devicetree/bindings/riscv/sunxi.yamldiff --git a/Documentation/devicetree/bindings/riscv/sunxi.yaml b/Documentation/devicetree/bindings/riscv/sunxi.yaml new file mode 100644 index 000000000000..564a89499894 --- /dev/null +++ b/Documentation/devicetree/bindings/riscv/sunxi.yaml@@ -0,0 +1,64 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/riscv/sunxi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Allwinner RISC-V SoC-based boards + +maintainers: + - Chen-Yu Tsai <wens@csie.org> + - Jernej Skrabec <jernej.skrabec@gmail.com> + - Samuel Holland <samuel@sholland.org> + +description: + Allwinner RISC-V SoC-based boards + +properties: + $nodename: + const: '/' + compatible: + oneOf: + - description: Dongshan Nezha STU SoM + items: + - const: 100ask,dongshan-nezha-stu + - const: allwinner,sun20i-d1 + + - description: D1 Nezha board + items: + - const: allwinner,d1-nezhaYou grow the list unnecessary. Several entries should be an enum, unless platform maintainer insists on such approach for all Allwinner Riscv platforms. Just be aware it will grow...
Having the binding document provide value to mere mortals and not only the automated tools is plus for me :-) . So obviously personally I like the current style more. But yeah, it's mainly a matter of preference :-) .