Thread (69 messages) 69 messages, 5 authors, 2019-02-18

Re: [PATCHv3 13/27] PCI: mobiveil: move irq chained handler setup out of DT parse

flat view

From: Subrahmanya Lingappa <hidden>
Date: 2019-02-08 12:28:23
Also in: linux-arm-kernel, linux-pci, lkml

On Tue, Jan 29, 2019 at 1:39 PM Z.q. Hou [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

Move irq_set_chained_handler_and_data() out of DT parse function.

Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Reviewed-by: Minghuan Lian <Minghuan.Lian@nxp.com>
---
V3:
 - No change

 drivers/pci/controller/pcie-mobiveil.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c
index c2848c22b466..db7ecb021c63 100644
--- a/drivers/pci/controller/pcie-mobiveil.c
+++ b/drivers/pci/controller/pcie-mobiveil.c
@@ -460,8 +460,6 @@ static int mobiveil_pcie_parse_dt(struct mobiveil_pcie *pcie)
                return -ENODEV;
        }

-       irq_set_chained_handler_and_data(pcie->irq, mobiveil_pcie_isr, pcie);
-
        return 0;
 }
@@ -902,6 +900,8 @@ static int mobiveil_pcie_probe(struct platform_device *pdev)
                goto error;
        }

+       irq_set_chained_handler_and_data(pcie->irq, mobiveil_pcie_isr, pcie);
+
        ret = devm_request_pci_bus_resources(dev, &pcie->resources);
        if (ret)
                goto error;
--
2.17.1
Reviewed-by: Subrahmanya Lingappa <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help