Thread (39 messages) 39 messages, 4 authors, 2012-01-19

Re: [PATCH 14/15] Bluetooth: Rename hdev->flags to hdev->compat_flags

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2012-01-18 19:18:54

Hi Johan,
quoted hunk ↗ jump to hunk
These flags mostly exist for legacy reasons and no new flags should be
added to this set, so compat_flags is a better name.

Signed-off-by: Johan Hedberg <redacted>
---
 drivers/bluetooth/bfusb.c        |   12 +++---
 drivers/bluetooth/bpa10x.c       |   12 +++---
 drivers/bluetooth/btmrvl_main.c  |    9 +++--
 drivers/bluetooth/btusb.c        |   20 +++++-----
 drivers/bluetooth/hci_ldisc.c    |    6 ++--
 drivers/bluetooth/hci_vhci.c     |    6 ++--
 include/net/bluetooth/hci.h      |    7 +---
 include/net/bluetooth/hci_core.h |    2 +-
 net/bluetooth/hci_conn.c         |    7 ++--
 net/bluetooth/hci_core.c         |   71 +++++++++++++++++++------------------
 net/bluetooth/hci_event.c        |   43 ++++++++++++-----------
 net/bluetooth/hci_sock.c         |    8 ++--
 net/bluetooth/mgmt.c             |   38 ++++++++++----------
 13 files changed, 121 insertions(+), 120 deletions(-)
diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c
index e97f42a..8f77290 100644
--- a/drivers/bluetooth/bfusb.c
+++ b/drivers/bluetooth/bfusb.c
@@ -191,7 +191,7 @@ static void bfusb_tx_complete(struct urb *urb)
 
 	atomic_dec(&data->pending_tx);
 
-	if (!test_bit(HCI_RUNNING, &data->hdev->flags))
+	if (!test_bit(HCI_RUNNING, &data->hdev->compat_flags))
 		return;
I do not like this change at all.

Can we just add a BT specific helper for setting/testing HCI_RUNNING and
hiding the fact of hdev->flags.

Regards

Marcel

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help