Thread (33 messages) 33 messages, 4 authors, 2024-01-17

Re: [PATCH v3 10/12] arm64: dts: exynos: gs101: update USI UART to use peric0 clocks

From: Sam Protsenko <semen.protsenko@linaro.org>
Date: 2024-01-16 17:59:09
Also in: linux-clk, linux-devicetree, linux-i2c, linux-samsung-soc, linux-serial, lkml

On Tue, Jan 9, 2024 at 7:01 AM Tudor Ambarus [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Get rid of the dummy clock and start using the cmu_peric0 clocks
for the usi_uart and serial_0 nodes.

Tested the serial at 115200, 1000000 and 3000000 baudrates,
everthing went fine.

Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
v3: no change
v2: identify and use gate clocks instead of divider clocks

 arch/arm64/boot/dts/exynos/google/gs101.dtsi | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
index 2d1344a202a9..6aa25cc4676e 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
+++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
@@ -180,14 +180,6 @@ HERA_CPU_SLEEP: cpu-hera-sleep {
                };
        };

-       /* TODO replace with CCF clock */
-       dummy_clk: clock-3 {
-               compatible = "fixed-clock";
-               #clock-cells = <0>;
-               clock-frequency = <12345>;
-               clock-output-names = "pclk";
-       };
-
        /* ect node is required to be present by bootloader */
        ect {
        };
@@ -367,7 +359,8 @@ usi_uart: usi@10a000c0 {
                        ranges;
                        #address-cells = <1>;
                        #size-cells = <1>;
-                       clocks = <&dummy_clk>, <&dummy_clk>;
+                       clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI0_UART_CLK>,
+                                <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_0>;
That looks much better.

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
quoted hunk ↗ jump to hunk
                        clock-names = "pclk", "ipclk";
                        samsung,sysreg = <&sysreg_peric0 0x1020>;
                        samsung,mode = <USI_V2_UART>;
@@ -378,7 +371,8 @@ serial_0: serial@10a00000 {
                                reg = <0x10a00000 0xc0>;
                                interrupts = <GIC_SPI 634
                                              IRQ_TYPE_LEVEL_HIGH 0>;
-                               clocks = <&dummy_clk 0>, <&dummy_clk 0>;
+                               clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI0_UART_CLK>,
+                                        <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_0>;
                                clock-names = "uart", "clk_uart_baud0";
                                samsung,uart-fifosize = <256>;
                                status = "disabled";
--
2.43.0.472.g3155946c3a-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help