Thread (33 messages) 33 messages, 4 authors, 2024-01-17

Re: [PATCH v3 04/12] tty: serial: samsung: prepare for different IO types

From: Krzysztof Kozlowski <hidden>
Date: 2024-01-10 08:07:08
Also in: linux-clk, linux-devicetree, linux-i2c, linux-samsung-soc, linux-serial, lkml

On 09/01/2024 13:58, Tudor Ambarus wrote:
GS101's Connectivity Peripheral blocks (peric0/1 blocks) which
include the I3C and USI (I2C, SPI, UART) only allow 32-bit
register accesses. If using 8-bit register accesses, a SError
Interrupt is raised causing the system unusable.

Instead of specifying the reg-io-width = 4 everywhere, for each node,
the requirement should be deduced from the compatible.

Prepare the samsung tty driver to allow IO types different than
UPIO_MEM. ``struct uart_port::iotype`` is an unsigned char where all
its 8 bits are exposed to uapi. We can't make NULL checks on it to
verify if it's set, thus always set it from the driver's data.
Use u8 for the ``iotype`` member of ``struct s3c24xx_uart_info`` to
emphasize that the iotype is an 8 bit mask.

Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
Reviewed-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help