Re: [PATCH V2 02/12] clk: mediatek: reset: Use simple reset operations
From: Rex-BC Chen <hidden>
Date: 2022-04-22 04:58:00
Also in:
linux-clk, linux-mediatek, lkml
On Thu, 2022-04-21 at 11:08 +0200, AngeloGioacchino Del Regno wrote:
Il 20/04/22 15:05, Rex-BC Chen ha scritto:quoted
There are two version for clock reset register control of MediaTek SoCs. The reset operations before MT8183 can use simple reset to cover. Therefore, we replace mtk_reset_ops with reset_simple_ops. In addition, we also rename mtk_register_reset_controller to mtk_register_reset_controller_simple. Signed-off-by: Rex-BC Chen <redacted>Hello Rex, have you tested this? It won't work. reset-simple is not using regmap, and it requires you to pass a struct reset_simple_data through drvdata. Besides, I like that we are using regmap, while reset_simple simply uses readl/writel... so if you want to use that driver, which is good to reduce duplication, you should also implement support for regmap in the form of reset_simple_regmap_ops. Regards, Angelo
Hello Angelo, Yes, I also notice the error.. The data we used is not reset_simple_data. I will drop using reset_simple_ops and remain original functions in next version. BRs, Rex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel