On Thu, Apr 21, 2022 at 5:14 PM Chen-Yu Tsai [off-list ref] wrote:

On Thu, Apr 21, 2022 at 5:07 PM AngeloGioacchino Del Regno
[off-list ref] wrote:

quoted

Il 20/04/22 15:05, Rex-BC Chen ha scritto:

quoted

Add a new file "reset.h" to place some definitions for clock reset.

Signed-off-by: Rex-BC Chen <redacted>

Right now, you're adding the enum mtk_reset_version and *then* you're
moving it to the new reset.h header, but does that really make sense?

I think that this series would be cleaner if you add this header from
the start, so that you place the aforementioned enumeration directly
in here...

...so we would have a commit that moves the mtk_clk_register_rst_ctrl()
function from clk-mtk.h to a newly created reset.h, mentioning in the
commit description that it's all about preparing for a coming cleanup,
then the addition of enum mtk_reset_version would be in
`clk: mediatek: reset: Merge and revise reset register function` directly
into reset.h.

And probably name it mtk-reset.h ? 'reset.h' is a bit too generic, and
I'm sure there are multiple files with the same name throughout the
kernel source tree.

On second thought, please ignore my comment.

ChenYu

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel