Re: [PATCH RESEND 1/3] topology: Represent clusters of CPUs within a die
From: Peter Zijlstra <peterz@infradead.org>
Date: 2021-10-07 10:39:00
Also in:
linux-acpi, lkml
On Thu, Oct 07, 2021 at 11:30:36PM +1300, Barry Song wrote:
On Thu, Oct 7, 2021 at 2:55 AM Peter Zijlstra [off-list ref] wrote:quoted
On Thu, Oct 07, 2021 at 01:50:43AM +1300, Barry Song wrote:quoted
On Thu, Oct 7, 2021 at 1:20 AM Peter Zijlstra [off-list ref] wrote:quoted
On Wed, Oct 06, 2021 at 11:50:35PM +1300, Barry Song wrote:quoted
quoted
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c index 7cb31d959f33..fc0836f460fb 100644 --- a/drivers/base/arch_topology.c +++ b/drivers/base/arch_topology.c@@ -622,7 +622,8 @@ void update_siblings_masks(unsigned int cpuid) if (cpuid_topo->package_id != cpu_topo->package_id) continue; - if (cpuid_topo->cluster_id == cpu_topo->cluster_id) { + if (cpuid_topo->cluster_id == cpu_topo->cluster_id && + cpuid_topo->cluster_id != -1) { cpumask_set_cpu(cpu, &cpuid_topo->cluster_sibling); cpumask_set_cpu(cpuid, &cpu_topo->cluster_sibling); }Hi Peter, Would you like to change this line in your tree?Can you please double check: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=sched/nextyes. It is correct for patch 1/3, thanks!oops, there is a typo there: + if (cpuid_topo->cluster_id == cpu_topo->cluster_id && + cpuid_topo->clister_id != -1) { clister should be cluster.
Yeah, my bad, typing so hard... :-) Already fixed. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel