On Fri, Oct 01, 2021 at 04:22:46PM -0700, Tim Chen wrote:

On Fri, 2021-10-01 at 16:57 +0200, Peter Zijlstra wrote:

quoted

The one questino I have is, do we want default y?

I also agree that default y is preferable.

I'll change at least the x86 one to:

	default y
	depends on SMP

quoted

The one nit I have is the Kconfig text, I'm not really sure that's
clarifying what a cluster is.

Do you have a preference of a different name other than cluster?
Or simply better documentation on what a cluster is for ARM64
and x86 in Kconfig?

Yes, better wording as to what a cluster is. Currently the x86 and arm64
ones actually differ:

x86:
	help
	 Cluster scheduler support improves the CPU scheduler's decision
	 making when dealing with machines that have clusters of CPUs
	 sharing L2 cache. If unsure say N here.

arm64:
	help
	  Cluster scheduler support improves the CPU scheduler's decision
	  making when dealing with machines that have clusters(sharing internal
	  bus or sharing LLC cache tag). If unsure say N here.


(also, all this stuff being replicated across arch/*/Kconfig seems
unfortunate)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel