RE: [PATCH V11 2/7] clk: imx: add scu clock common part
From: Aisheng Dong <aisheng.dong@nxp.com>
Date: 2018-12-14 02:28:32
Also in:
linux-clk
-----Original Message----- From: Stephen Boyd [mailto:sboyd@kernel.org]
[...]
Quoting Aisheng Dong (2018-12-13 17:44:55)quoted
quoted
quoted
How would you suggest for this situation?I suggest the defines just go into the clk driver. Is that a workable solution or does something not work?Are you suggesting me to doing it now? As the patch is already in Shawn's tree, but I think I can do it and clean up the file in Shawn's tree later. However, only moving the clk related defines into clk driver is not enough. The driver compiling still depends on the resource ID file which is shared by power domain driver and clk driver (and possible many others). So we still have dependency issues.Do the resources need to be defined in one place either? Or can they be spread to all the drivers that use them?
I guess no. They're mostly shared among a variety of driver, power domain, clk and
other possible clients.
e.g. power domain use all of them to specify domain in device tree.
+ adma_lpuart0: serial@5a060000 {
+ compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+ reg = <0x5a060000 0x1000>;
+ interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-parent = <&gic>;
+ clocks = <&adma_lpcg IMX8QXP_ADMA_LPCG_UART0_BAUD_CLK>;
+ clock-names = "ipg";
+ power-domains = <&pd IMX_SC_R_UART_0>;
+ status = "disabled";
+ };
https://patchwork.kernel.org/patch/10677311/
Regards
Dong Aisheng
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel