Re: [PATCH V11 1/7] clk: imx: add configuration option for mmio clks
From: Stephen Boyd <sboyd@kernel.org>
Date: 2018-12-13 07:57:37
Also in:
linux-clk
Quoting Aisheng Dong (2018-12-12 17:07:52)
quoted hunk ↗ jump to hunk
The patch introduces CONFIG_MXC_CLK option for legacy MMIO clocks, this is required to compile legacy MMIO clock conditionally when adding SCU based clocks for MX8 platforms later. Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <kernel@pengutronix.de> Cc: Fabio Estevam <redacted> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Michael Turquette <mturquette@baylibre.com> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index a47430b..8a9440a 100644 --- a/drivers/clk/Makefile +++ b/drivers/clk/Makefile@@ -72,7 +72,7 @@ obj-$(CONFIG_ARCH_DAVINCI) += davinci/ obj-$(CONFIG_H8300) += h8300/ obj-$(CONFIG_ARCH_HISI) += hisilicon/ obj-y += imgtec/ -obj-$(CONFIG_ARCH_MXC) += imx/ +obj-y += imx/ obj-y += ingenic/ obj-$(CONFIG_ARCH_K3) += keystone/ obj-$(CONFIG_ARCH_KEYSTONE) += keystone/diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig new file mode 100644 index 0000000..37478ba --- /dev/null +++ b/drivers/clk/imx/Kconfig@@ -0,0 +1,5 @@ +# SPDX-License-Identifier: GPL-2.0 +# common clock support for NXP i.MX SoC family. +config MXC_CLK + bool + def_bool (ARCH_MXC && !ARM64) || (ARCH_MXC && ARM64 && SOC_IMX8MQ)
Ok I looked closer, SOC_IMX8MQ is only being introduced now and has only been in linux-next for a few days. Having such a config symbol is highly unusual for arm64 code. Has that been accepted by arm-soc? I don't know why it would be because we don't add SoC specific config options anymore. I imagine it will be rejected and we'll need to have this new MXC_CLK config be enabled in the defconfig instead of selected from the arch layer. Given all that, is there any damage if this is just a def_bool ARCH_MXC right now? If it's enabled on the platforms that don't use it because they have SCU, does it actually matter? Or we just get some code bloat? If it's just some extra code, then even more reason to make a user visible config option that can be selected in the configurations that care to save some space.
quoted hunk ↗ jump to hunk
diff --git a/drivers/clk/imx/Makefile b/drivers/clk/imx/Makefile index 5c0b11e..f850424 100644 --- a/drivers/clk/imx/Makefile +++ b/drivers/clk/imx/Makefile@@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 -obj-y += \ +obj-$(CONFIG_MXC_CLK) += \ clk.o \ clk-busy.o \ clk-composite-8m.o \
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel