-----Original Message-----
From: Stephen Boyd [mailto:sboyd@kernel.org]
Sent: Friday, December 14, 2018 9:31 AM
To: linux-clk@vger.kernel.org; Aisheng Dong <aisheng.dong@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org; mturquette@baylibre.com;
shawnguo@kernel.org; Fabio Estevam [off-list ref]; dl-linux-imx
[off-list ref]; kernel@pengutronix.de
Subject: RE: [PATCH V11 2/7] clk: imx: add scu clock common part

Quoting Aisheng Dong (2018-12-13 03:19:26)

quoted

quoted

-----Original Message-----
From: Stephen Boyd [mailto:sboyd@kernel.org] Quoting Aisheng Dong
(2018-12-12 17:07:55)

quoted

diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
index 37478ba..5c26f4e 100644
--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig

@@ -3,3 +3,9 @@
 config MXC_CLK
        bool
        def_bool (ARCH_MXC && !ARM64) || (ARCH_MXC && ARM64

&&

quoted

quoted

quoted

SOC_IMX8MQ)
+
+config MXC_CLK_SCU
+       bool "IMX SCU Clock"
+       depends on ARCH_MXC && ARM64

This should depend on the IMX_SCU config too, right? Otherwise
compilation will fail.

Yes, you're right. I will add it.

quoted

Plus, I can't seem to compile this driver regardless, because the
defines for the CLK messages are in some header file that is just
included in another header file, and that is all going through another tree.

Why?

quoted

quoted

Is there any reason why those defines can't just be written in the
clk-scu.h file introduced in this patch?

Sorry about that.
Yes, it depends on PM service headfile [1] which defines all the power
related service together by SCU protocol, including power domain/clk/reset

and etc.

quoted

(we probably should divide them to get a better separation from the start).
But Patch 4 depends on the resource ID headfile shared by most SCU client

users.

quoted

[1]
https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat

chwork.kernel.org%2Fpatch%2F10664137%2F&data=02%7C01%7Caishe
ng.don

quoted

g%40nxp.com%7Cea09bbc7dfbf424844bb08d66163c240%7C686ea1d3bc2b4
c6fa92cd

quoted

99c5c301635%7C0%7C0%7C636803478422100123&sdata=GwOYjZns%2
BJxLePnT5

quoted

6ZTzRuME3DQA5V8eukvRXCf1s0%3D&reserved=0
[2]
https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat

chwork.kernel.org%2Fpatch%2F10664125%2F&data=02%7C01%7Caishe
ng.don

quoted

g%40nxp.com%7Cea09bbc7dfbf424844bb08d66163c240%7C686ea1d3bc2b4
c6fa92cd

quoted

99c5c301635%7C0%7C0%7C636803478422100123&sdata=CJGAlaF4K3
uK3bYlEbC

quoted

sSRQssa25%2F%2BiPaI5y4x7grRc%3D&reserved=0

How would you suggest for this situation?

I suggest the defines just go into the clk driver. Is that a workable solution or
does something not work?

Are you suggesting me to doing it now?
As the patch is already in Shawn's tree, but I think I can do it and clean up
the file in Shawn's tree later.

However, only moving the clk related defines into clk driver is not enough.
The driver compiling still depends on the resource ID file which is shared
by power domain driver and clk driver (and possible many others).
So we still have dependency issues.

Any suggestion?

Regards
Dong Aisheng

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel