Quoting Aisheng Dong (2018-12-13 03:19:26)

quoted

-----Original Message-----
From: Stephen Boyd [mailto:sboyd@kernel.org]
Quoting Aisheng Dong (2018-12-12 17:07:55)

quoted

diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig index

37478ba..5c26f4e 100644

--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig

@@ -3,3 +3,9 @@
 config MXC_CLK
        bool
        def_bool (ARCH_MXC && !ARM64) || (ARCH_MXC && ARM64 &&

SOC_IMX8MQ)
+
+config MXC_CLK_SCU
+       bool "IMX SCU Clock"
+       depends on ARCH_MXC && ARM64

This should depend on the IMX_SCU config too, right? Otherwise compilation
will fail.

Yes, you're right. I will add it.

quoted

Plus, I can't seem to compile this driver regardless, because the defines for the
CLK messages are in some header file that is just included in another header
file, and that is all going through another tree. Why?

Is there any reason why those defines can't just be written in the clk-scu.h file
introduced in this patch?

Sorry about that.
Yes, it depends on PM service headfile [1] which defines all the power related service together
by SCU protocol, including power domain/clk/reset and etc. 
(we probably should divide them to get a better separation from the start).
But Patch 4 depends on the resource ID headfile shared by most SCU client users.

[1] https://patchwork.kernel.org/patch/10664137/
[2] https://patchwork.kernel.org/patch/10664125/

How would you suggest for this situation?

I suggest the defines just go into the clk driver. Is that a workable
solution or does something not work?


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel