Thread (26 messages) 26 messages, 5 authors, 2018-12-14

RE: [PATCH V11 1/7] clk: imx: add configuration option for mmio clks

From: Aisheng Dong <aisheng.dong@nxp.com>
Date: 2018-12-14 01:50:33
Also in: linux-clk

[...]
quoted
It make sense to me. No actual damage as we support multiplatforms
using both MXC_CLK and MXC_CLK_SCU on ARMv8. And for users who want
to
quoted
save one of them, they do can change via memuconfig later.
I will make it a def_bool ARCH_MXC.
Thanks for the suggestion.

BTW, as I also introduced SOC_IMX8QXP in Patch 4 and 7.
diff --git a/drivers/clk/imx/Makefile b/drivers/clk/imx/Makefile
+obj-$(CONFIG_SOC_IMX8QXP) += clk-imx8qxp.o clk-imx8qxp-lpcg.o
According to your former suggestion, I think we should remove it.
So I'm going to make imx8qxp clk an user selectable configuration
option which will select the common MXC_CLK_SCU. So a bit difference
from former discussion, MXC_CLK_SCU will still be kept a hide option.

This way is mostly like how QCOM does and should work for IMX as well.

Then it will look like:
config MXC_CLK_SCU
        bool

config CLK_IMX8QXP
        bool "IMX8QXP SCU Clock"
        depends on ARCH_MXC && IMX_SCU && ARM64
        select MXC_CLK_SCU
        help
          Build the driver for IMX8QXP SCU based clocks.

If any issue, please let me know.
Ok, so a library pattern, where MXC_CLK_SCU is the library of code that various
SoC specific clk drivers use. Seems fine to me.
Thanks.
Can you help take a look at V12 series to see if this new approach
is okay to you?

Regards
Dong Aisheng
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help