[linux-sunxi] Re: [PATCH v3 27/30] ARM: dts: sun8i: h3: use calibration for ths

? 2018?9?6? GMT+08:00 ??7:51:15, Maxime Ripard [off-list ref] ??:

On Thu, Sep 06, 2018 at 01:47:47PM +0200, Philipp Rossak wrote:

quoted

On 04.09.2018 18:46, Emmanuel Vadot wrote:

quoted

quoted

+			/* Data cells */
+			thermal_calibration: calib at 234 {
+				reg = <0x234 0x8>;
+			};

  You are declaring 8 bytes of calibration data but to my knowledge

it's

quoted

quoted

only 2 bytes per sensor, so 2 bytes for H3.
  Am I missing something ?

  Thanks,

Emmanuel you are right, it is 2 bytes per Sensor and should be 2

bytes for

quoted

H3, but the thermal calibration data field is on all chips 64 bit

wide - so

quoted

8 bytes. So I'm reading here the complete calibration data field.

Having one cell per channel would make more sense I guess.

I have mentioned that this is impossible because of wrong
addressing caused by LE2BE in SID driver.

Maxime