Thread (79 messages) 79 messages, 8 authors, 2018-09-11

[linux-sunxi] [PATCH v3 21/30] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor

From: Philipp Rossak <hidden>
Date: 2018-08-30 20:47:06
Also in: linux-devicetree, linux-iio, lkml


On 30.08.2018 22:00, Philipp Rossak wrote:
On 30.08.2018 18:27, Ond?ej Jirman wrote:
quoted
quoted
+static int sun8i_h3_calibrate(struct sun4i_gpadc_iio *info)
+{
+//??? regmap_write(info->regmap, SUNXI_THS_CDATA_0_1,
+//??????????? info->calibration_data[0]);
+//??? regmap_write(info->regmap, SUNXI_THS_CDATA_2_3,
+//??????????? info->calibration_data[1]);
This should probably be implemented, or left out completely.

regards,
?? o.
Thanks you are right!
This should be implemented! I will fix this in the next version!

Thanks,
Philipp
I just realized this function need to check if calibration datas are 
available. Writing zeros to the calibration data regs "breaks" the 
thermal sensor.

Philipp
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help