Hi Abhishek,

On 2/3/2018 5:07 PM, Abhishek Sahu wrote:

On 2018-01-29 10:41, Sricharan R wrote:

quoted

Signed-off-by: Sricharan R <redacted>
---
?arch/arm/boot/dts/Makefile????????????????????? |? 1 +
?arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dts | 14 ++++++++++++++
?2 files changed, 15 insertions(+)
?create mode 100644 arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 68e4b15..0104ba2 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile

@@ -727,6 +727,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \

???? qcom-ipq4019-ap.dk01.1-c2.dtb \
???? qcom-ipq4019-ap.dk04.1-c1.dtb \
???? qcom-ipq4019-ap.dk04.1-c5.dtb \
+??? qcom-ipq4019-ap.dk04.1-c3.dtb \
???? qcom-ipq8064-ap148.dtb \
???? qcom-msm8660-surf.dtb \
???? qcom-msm8960-cdp.dtb \

diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dts

b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dts
new file mode 100644
index 0000000..7a93fc4

--- /dev/null
+++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dts

@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2017, The Linux Foundation. All rights reserved.
+
+#include "qcom-ipq4019-ap.dk04.1.dtsi"
+
+/ {
+??? model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK04.1-C3";
+
+??? soc {
+??????? nand: qpic-nand at 79b0000 {
+??????????? status = "disabled";
+??????? };

?Normally we need to disable in base dtsi and enable in
?board dtsi so that base dtsi will always work in all the
?boards. Now If We load the base dtsi in any DK04 board
?other than C1, then nand failure will come.

 Hmm, qpic nand is not there only on C3 and available in rest
 of dk04-c* variants. So it should work, downstream also
 does it in same way. Anyways, from a readability point, feel that
 better to make these uncommon configurations in each board file
 specifically rather than putting in common file and changing like this.

Regards,
 Sricharan


-- 
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation