[PATCH 06/14] ARM: dts: sun8i: Add cpu0 label to sun8i-h3.dtsi

On Sat, Jun 25, 2016 at 6:51 AM, Ond?ej Jirman [off-list ref] wrote:

Hello,

comments below.

On 24.6.2016 05:48, Chen-Yu Tsai wrote:

quoted

On Fri, Jun 24, 2016 at 3:20 AM,  [off-list ref] wrote:

quoted

From: Ondrej Jirman <redacted>

Add label to the first cpu so that it can be referenced
from derived dts files.

Signed-off-by: Ondrej Jirman <redacted>
---
 arch/arm/boot/dts/sun8i-h3.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
index 9938972..82faefc 100644
--- a/arch/arm/boot/dts/sun8i-h3.dtsi
+++ b/arch/arm/boot/dts/sun8i-h3.dtsi

@@ -52,7 +52,7 @@
                #address-cells = <1>;
                #size-cells = <0>;

-               cpu at 0 {
+               cpu0: cpu at 0 {
                        compatible = "arm,cortex-a7";
                        device_type = "cpu";
                        reg = <0>;

Can you also set the cpu clock here? It is part of the SoC
and does not belong in the board DTS files.

Do you mean operating-points, or something else? Different SBCs will
probably require different combinations of operating points just for
safety's sake, because they have different regulators and [some have
botched] thermal designs, so it might make sense to customize it for
differnt boards, and I don't feel adventurous enough setting it for all
H3 boards out there.

I meant clocks = <...> and clock-latency = <...>.

These 2 are part of the SoC.

The OPP can stay in the board files. It's a pity there's no standard
OPP table for H3 though. :(

ChenYu

Or is this comment related to the missing cpu clock rate message I see
on every boot?

[    0.058912] /cpus/cpu at 0 missing clock-frequency property

regards,
  Ondrej

quoted

Otherwise this one looks good.

ChenYu

quoted

--
2.9.0