On 25.6.2016 02:54, Chen-Yu Tsai wrote:

On Sat, Jun 25, 2016 at 8:35 AM, Ond?ej Jirman [off-list ref] wrote:

quoted

On 24.6.2016 05:09, Chen-Yu Tsai wrote:

quoted

quoted

+static int sun8i_ths_h3_init(struct platform_device *pdev,
+                            struct sun8i_ths_data *data)
+{
+       int ret;
+       size_t callen;
+       s32 *caldata;
+
+       data->busclk = devm_clk_get(&pdev->dev, "ahb");
+       if (IS_ERR(data->busclk)) {
+               ret = PTR_ERR(data->busclk);
+               dev_err(&pdev->dev, "failed to get ahb clk: %d\n", ret);
+               return ret;
+       }
+
+       data->clk = devm_clk_get(&pdev->dev, "ths");
+       if (IS_ERR(data->clk)) {
+               ret = PTR_ERR(data->clk);
+               dev_err(&pdev->dev, "failed to get ths clk: %d\n", ret);
+               return ret;
+       }
+
+       data->reset = devm_reset_control_get(&pdev->dev, "ahb");

IIRC with the new shared reset control stuff merged, you are supposed
to specify whether you want a shared or exclusive one when you ask for
it.

Here devm_reset_control_get will get the exclusive reference. So this
should be ok.

See https://patchwork.kernel.org/patch/9158691/

The generic ones might be removed later on. I remember in another thread
it was asked that new users should use the explicit API, and avoid having
to be converted.

I see, thank you, I'll change that.

regards,
  Ondrej

ChenYu

quoted

regards,
  Ondrej

quoted

Regards
ChenYu

quoted

+MODULE_LICENSE("GPL v2");
--
2.9.0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160625/e8684941/attachment.sig>