Thread (43 messages) flat view 43 messages, 5 authors, 2016-07-25

[linux-sunxi] [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One

From: Ondřej Jirman <hidden>
Date: 2016-06-24 22:40:10
Also in: linux-devicetree, lkml

Hi Julian,

thank you for the review. You're right. I added the pinctrl client
nodes. Also the patches were split incorrectly, so I fixed that too.

regards,
  Ondrej

On 24.6.2016 04:51, Julian Calaby wrote:
Hi Ondrej,

On Fri, Jun 24, 2016 at 5:21 AM,  [off-list ref] wrote:
quoted
From: Ondrej Jirman <redacted>

Xulong Orange Pi One uses GPIO based regulator that
switches between two voltages: 1.1V and 1.3V. The
regulator is controlled from the PL6 pin.

Signed-off-by: Ondrej Jirman <redacted>
---
 arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
index 0adf932..ce4ba91 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
@@ -88,6 +88,25 @@
                        gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>;
                };
        };
+
+       vdd_soc: gpio-regulator {
+               compatible = "regulator-gpio";
+
+               regulator-name = "soc-vdd-supply";
+               regulator-min-microvolt = <1100000>;
+               regulator-max-microvolt = <1300000>;
+               regulator-boot-on;
+               regulator-type = "voltage";
+
+               gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>;
+               states = <1100000 0x0
+                         1300000 0x1>;
+
+               startup-delay-us = <100000>;
+               enable-active-high;
Don't you need to reference the new pinctl node in this one?

Thanks,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160625/e57828ad/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help