Thread (156 messages) flat view 156 messages, 25 authors, 2015-01-30

[PATCH v7 07/17] ARM64 / ACPI: Disable ACPI if FADT revision is less than 5.1

From: Hanjun Guo <hidden>
Date: 2015-01-20 03:05:57
Also in: linux-acpi, lkml

On 2015?01?19? 19:50, Catalin Marinas wrote:
On Wed, Jan 14, 2015 at 03:04:55PM +0000, Hanjun Guo wrote:
quoted
--- a/arch/arm64/kernel/acpi.c
+++ b/arch/arm64/kernel/acpi.c
[...]
quoted
@@ -64,8 +88,13 @@ void __init acpi_boot_table_init(void)
  		return;

  	/* Initialize the ACPI boot-time table parser. */
-	if (acpi_table_init())
+	if (acpi_table_init()) {
  		disable_acpi();
+		return;
+	}
+
+	if (acpi_table_parse(ACPI_SIG_FADT, acpi_parse_fadt))
+		pr_err("Can't find FADT or error happened during parsing FADT\n");
  }
Do you need a disable_acpi() call here as well?
Yes, if we can not find the FADT table, we should disable ACPI, I will
update it in next version, thanks for pointing this out :)

Thanks
Hanjun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help