Hi guys,

On Wed, Jul 02, 2014 at 01:10:00AM +0000, Peter Chen wrote:

quoted

On 07/01/2014 02:42 PM, Alexandre Belloni wrote:

quoted

quoted

quoted

quoted

quoted

Well, there is nothing specific about the Berlin CI. Some
subsystems use the 'generic' keyword in these cases. Do you see a
particular reason I should use some Berlin related compatible here?

quoted

quoted

quoted

quoted

Not must, one suggestion is: can you change the compatible string
to "chipidea-usb-generic"?

quoted

quoted

quoted

I don't know about ChipIdea/ARC/DW's product portfolio but I guess
the compatible should also carry '2.0' or 'usb2' in it. Or we just
use some version number like 'chipidea,ci13000' or 'chipidea,ci13xxx'.

quoted

quoted

The recommended format for compatible string is:
"manufacturer,model", I agree with "chipidea,ci13xxx", thanks.

quoted

I think we should probably avoid using wildcards in the compatible
string.

    I'm sure wildcards shouldn't be allowed there. :-)

Then, what's your guys recommend, how about "chipidea,usb2-generic"?

So what do you think? "chipidea,ci13", "chipidea,usb2-generic" or
something else?

I tend to prefer something without the 'generic' keyword.

After updating the compatible I'll send a v3 based on USB changes
introducing the generic PHY support[1].

[1] https://lkml.org/lkml/2014/7/15/330


Antoine

-- 
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com