On 07/01/2014 02:21 AM, Peter Chen wrote:

On Mon, Jun 30, 2014 at 03:33:13PM +0200, Antoine T?nart wrote:

quoted

On Fri, Jun 27, 2014 at 11:25:07AM +0800, Peter Chen wrote:

quoted

On Tue, Jun 24, 2014 at 12:35:16PM +0200, Antoine T?nart wrote:

quoted

+
+static const struct of_device_id ci_hdrc_generic_of_match[] = {
+	{ .compatible = "chipidea-usb" },
+	{ }
+};

Even as a generic driver, you can also use your own compatible string.

Well, there is nothing specific about the Berlin CI. Some subsystems
use the 'generic' keyword in these cases. Do you see a particular reason
I should use some Berlin related compatible here?

Not must, one suggestion is: can you change the compatible string
to "chipidea-usb-generic"?

I don't know about ChipIdea/ARC/DW's product portfolio but I guess
the compatible should also carry '2.0' or 'usb2' in it. Or we just
use some version number like 'chipidea,ci13000' or 'chipidea,ci13xxx'.

Sebastian