Hello,

On Tue, Jun 24, 2014 at 07:51:01PM +0900, Jingoo Han wrote:

On Tuesday, June 24, 2014 7:35 PM, Antoine Tenart wrote:

quoted

Add a generic ChipIdea driver, with optional PHY and clock, to support
ChipIdea controllers that doesn't need specific functions.

s/doesn't/don't

quoted

Needed for the Marvell Berlin SoCs SUB controllers.

s/SUB/USB

Right, I'll fix these.

quoted

+
+MODULE_DESCRIPTION("Generic ChipIdea HDRC USB binding");
+MODULE_AUTHOR("Antoine T?nart [off-list ref]");
+MODULE_LICENSE("GPL");

How about "GPL v2"?

Well, "GPL" stands for "GNU Public License v2 or later" as documented
in:
http://lxr.free-electrons.com/source/include/linux/module.h#L100

Is there a reason I should use "GPLv2"? Or is this a best practice?

Thanks!

Antoine

-- 
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com