[PATCH v2 07/12] usb: chipidea: add a generic driver
From: Sergei Shtylyov <hidden>
Date: 2014-07-01 15:18:46
Also in:
lkml
From: Sergei Shtylyov <hidden>
Date: 2014-07-01 15:18:46
Also in:
lkml
Hello. On 07/01/2014 02:42 PM, Alexandre Belloni wrote:
quoted
quoted
quoted
quoted
Well, there is nothing specific about the Berlin CI. Some subsystems use the 'generic' keyword in these cases. Do you see a particular reason I should use some Berlin related compatible here?
quoted
quoted
quoted
Not must, one suggestion is: can you change the compatible string to "chipidea-usb-generic"?
quoted
quoted
I don't know about ChipIdea/ARC/DW's product portfolio but I guess the compatible should also carry '2.0' or 'usb2' in it. Or we just use some version number like 'chipidea,ci13000' or 'chipidea,ci13xxx'.
quoted
The recommended format for compatible string is: "manufacturer,model", I agree with "chipidea,ci13xxx", thanks.
I think we should probably avoid using wildcards in the compatible string.
I'm sure wildcards shouldn't be allowed there. :-)
WBR, Sergei