Thread (60 messages) 60 messages, 5 authors, 2014-06-17

[PATCH 21/22] ARM: sunxi: Add Allwinner A23 dtsi

From: Chen-Yu Tsai <hidden>
Date: 2014-05-26 04:02:45
Also in: linux-devicetree, linux-serial, lkml

On Mon, May 26, 2014 at 3:38 AM, Maxime Ripard
[off-list ref] wrote:
On Fri, May 23, 2014 at 03:51:24PM +0800, Chen-Yu Tsai wrote:
quoted
The Allwinner A23 is a tablet oriented SoC with 2 Cortex-A7 cores
and a Mali-400MP2 GPU.

Signed-off-by: Chen-Yu Tsai <redacted>
---
 arch/arm/boot/dts/sun8i-a23.dtsi | 524 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 524 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun8i-a23.dtsi
diff --git a/arch/arm/boot/dts/sun8i-a23.dtsi b/arch/arm/boot/dts/sun8i-a23.dtsi
new file mode 100644
index 0000000..1cff087
--- /dev/null
+++ b/arch/arm/boot/dts/sun8i-a23.dtsi
@@ -0,0 +1,524 @@
+/*
+ * Copyright 2014 Chen-Yu Tsai
+ *
+ * Chen-Yu Tsai <wens@csie.org>
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/include/ "skeleton.dtsi"
+
+/ {
+     interrupt-parent = <&gic>;
+
+     aliases {
+             serial0 = &uart0;
+             serial1 = &uart1;
+             serial2 = &uart2;
+             serial3 = &uart3;
+             serial4 = &uart4;
+             serial5 = &r_uart;
+     };
+
+
+     cpus {
+             enable-method = "allwinner,sun8i-a23";
+             #address-cells = <1>;
+             #size-cells = <0>;
+
+             cpu at 0 {
+                     compatible = "arm,cortex-a7";
+                     device_type = "cpu";
+                     reg = <0>;
+                     clocks = <&cpu>;
+             };
+
+             cpu at 1 {
+                     compatible = "arm,cortex-a7";
+                     device_type = "cpu";
+                     reg = <1>;
+                     clocks = <&cpu>;
The clocks attributes have not been merged yet.
I'll drop them until they are merged.
quoted
+             };
+     };
+
+     memory {
+             reg = <0x40000000 0x80000000>;
+     };
+
+     pmu {
+             compatible = "arm,cortex-a7-pmu", "arm,cortex-a15-pmu";
+             interrupts = <0 120 4>,
+                          <0 121 4>,
+                          <0 122 4>,
+                          <0 123 4>;
+     };
The PMU usually have as much interrupts as CPU core, so this is most
likely wrong.
I see. I just copied the interrupts that were listed in Allwinner sources.
I'll drop the extra 2.
Also, do you know if the arch timers are usable on the A23?
I tried them (copying the "timer" section from A20 dtsi), but the system
just hangs. I think I'll leave this for a follow up series.
quoted
+
+     clocks {
+             #address-cells = <1>;
+             #size-cells = <1>;
+             ranges;
+
+             osc24M: osc24M_clk {
+                     #clock-cells = <0>;
+                     compatible = "fixed-clock";
+                     clock-frequency = <24000000>;
+                     clock-output-names = "osc24M";
+             };
+
+             osc32k: osc32k_clk {
+                     #clock-cells = <0>;
+                     compatible = "fixed-clock";
+                     clock-frequency = <32768>;
+                     clock-output-names = "osc32k";
+             };
+
+             pll1: clk at 01c20000 {
+                     #clock-cells = <0>;
+                     compatible = "allwinner,sun8i-a23-pll1-clk";
+                     reg = <0x01c20000 0x4>;
+                     clocks = <&osc24M>;
+                     clock-output-names = "pll1";
+             };
+
+             pll6: clk at 01c20028 {
+                     #clock-cells = <1>;
+                     compatible = "allwinner,sun6i-a31-pll6-clk";
+                     reg = <0x01c20028 0x4>;
+                     clocks = <&osc24M>;
+                     clock-output-names = "pll6_other", "pll6";
+             };
+
+             cpu: cpu_clk at 01c20050 {
+                     #clock-cells = <0>;
+                     compatible = "allwinner,sun4i-a10-cpu-clk";
+                     reg = <0x01c20050 0x4>;
+
+                     /*
+                      * PLL1 is listed twice here.
+                      * While it looks suspicious, it's actually documented
+                      * that way both in the datasheet and in the code from
+                      * Allwinner.
+                      */
+                     clocks = <&osc32k>, <&osc24M>, <&pll1>, <&pll1>;
+                     clock-output-names = "cpu";
+             };
+
+             axi: axi_clk at 01c20050 {
+                     #clock-cells = <0>;
+                     /*
+                      * AXI clock on A23 is actually wider,
+                      * but extra bit is useless for divider
+                      */
Then please add a new compatible for this, even though we're not doing
anything differently (yet).
Will do.
quoted
+                     compatible = "allwinner,sun4i-a10-axi-clk";
+                     reg = <0x01c20050 0x4>;
+                     clocks = <&cpu>;
+                     clock-output-names = "axi";
+             };
+
+             ahb1_pll6: ahb1_pll6_clk at 01c20054 {
+                     #clock-cells = <0>;
+                     compatible = "allwinner,sun6i-a31-ahb1-pll6-clk";
+                     reg = <0x01c20054 0x4>;
+                     clocks = <&pll6 0>;
+                     clock-output-names = "ahb1_pll6";
+             };
+
+             ahb1_mux: ahb1_mux_clk at 01c20054 {
+                     #clock-cells = <0>;
+                     compatible = "allwinner,sun6i-a31-ahb1-mux-clk";
+                     reg = <0x01c20054 0x4>;
+                     clocks = <&osc32k>, <&osc24M>, <&axi>, <&ahb1_pll6>;
+                     clock-output-names = "ahb1_mux";
+             };
+
+             ahb1: ahb1_clk at 01c20054 {
+                     #clock-cells = <0>;
+                     compatible = "allwinner,sun4i-a10-ahb-clk";
+                     reg = <0x01c20054 0x4>;
+                     clocks = <&ahb1_mux>;
+                     clock-output-names = "ahb1";
+             };
+
+             ahb1_gates: clk at 01c20060 {
+                     #clock-cells = <1>;
+                     compatible = "allwinner,sun8i-a23-ahb1-gates-clk";
+                     reg = <0x01c20060 0x8>;
+                     clocks = <&ahb1>;
+                     clock-output-names = "ahb1_mipidsi", "ahb1_dma",
+                                     "ahb1_mmc0", "ahb1_mmc1", "ahb1_mmc2",
+                                     "ahb1_nand", "ahb1_sdram",
+                                     "ahb1_hstimer", "ahb1_spi0",
+                                     "ahb1_spi1", "ahb1_otg", "ahb1_ehci",
+                                     "ahb1_ohci", "ahb1_ve", "ahb1_lcd",
+                                     "ahb1_csi", "ahb1_be",  "ahb1_fe",
+                                     "ahb1_gpu", "ahb1_spinlock",
+                                     "ahb1_drc";
+             };
+
+             apb1: apb1_clk at 01c20054 {
+                     #clock-cells = <0>;
+                     compatible = "allwinner,sun4i-a10-apb0-clk";
+                     reg = <0x01c20054 0x4>;
+                     clocks = <&ahb1>;
+                     clock-output-names = "apb1";
+             };
+
+             apb1_gates: clk at 01c20068 {
+                     #clock-cells = <1>;
+                     compatible = "allwinner,sun8i-a23-apb1-gates-clk";
+                     reg = <0x01c20068 0x4>;
+                     clocks = <&apb1>;
+                     clock-output-names = "apb1_codec", "apb1_pio",
+                                     "apb1_daudio0", "apb1_daudio1";
+             };
+
+             apb2_mux: apb2_mux at 01c20058 {
+                     #clock-cells = <0>;
+                     compatible = "allwinner,sun4i-a10-apb1-mux-clk";
+                     reg = <0x01c20058 0x4>;
+                     clocks = <&osc32k>, <&osc24M>, <&pll6 0>, <&pll6 0>;
+                     clock-output-names = "apb2_mux";
+             };
It doesn't look to be ordered by physical address.
My bad.
quoted
+             apb2: apb2 at 01c20058 {
+                     #clock-cells = <0>;
+                     compatible = "allwinner,sun6i-a31-apb2-div-clk";
+                     reg = <0x01c20058 0x4>;
+                     clocks = <&apb2_mux>;
+                     clock-output-names = "apb2";
+             };
+
+             apb2_gates: clk at 01c2006c {
+                     #clock-cells = <1>;
+                     compatible = "allwinner,sun8i-a23-apb2-gates-clk";
+                     reg = <0x01c2006c 0x4>;
+                     clocks = <&apb2>;
+                     clock-output-names = "apb2_i2c0", "apb2_i2c1",
+                                     "apb2_i2c2", "apb2_uart0",
+                                     "apb2_uart1", "apb2_uart2",
+                                     "apb2_uart3", "apb2_uart4";
+             };
+
+             mmc0_clk: clk at 01c20088 {
+                     #clock-cells = <0>;
+                     compatible = "allwinner,sun4i-a10-mod0-clk";
+                     reg = <0x01c20088 0x4>;
+                     clocks = <&osc24M>, <&pll6 0>;
+                     clock-output-names = "mmc0";
+             };
+
+             mmc1_clk: clk at 01c2008c {
+                     #clock-cells = <0>;
+                     compatible = "allwinner,sun4i-a10-mod0-clk";
+                     reg = <0x01c2008c 0x4>;
+                     clocks = <&osc24M>, <&pll6 0>;
+                     clock-output-names = "mmc1";
+             };
+
+             mmc2_clk: clk at 01c20090 {
+                     #clock-cells = <0>;
+                     compatible = "allwinner,sun4i-a10-mod0-clk";
+                     reg = <0x01c20090 0x4>;
+                     clocks = <&osc24M>, <&pll6 0>;
+                     clock-output-names = "mmc2";
+             };
+
+             spi0_clk: clk at 01c200a0 {
+                     #clock-cells = <0>;
+                     compatible = "allwinner,sun4i-a10-mod0-clk";
+                     reg = <0x01c200a0 0x4>;
+                     clocks = <&osc24M>, <&pll6 0>;
+                     clock-output-names = "spi0";
+             };
+
+             spi1_clk: clk at 01c200a4 {
+                     #clock-cells = <0>;
+                     compatible = "allwinner,sun4i-a10-mod0-clk";
+                     reg = <0x01c200a4 0x4>;
+                     clocks = <&osc24M>, <&pll6 0>;
+                     clock-output-names = "spi1";
+             };
+     };
+
+     soc at 01c00000 {
+             compatible = "simple-bus";
+             #address-cells = <1>;
+             #size-cells = <1>;
+             ranges;
+
+             pio: pinctrl at 01c20800 {
+                     compatible = "allwinner,sun8i-a23-pinctrl";
+                     reg = <0x01c20800 0x400>;
+                     interrupts = <0 11 4>,
+                                  <0 15 4>,
+                                  <0 17 4>;
+                     clocks = <&apb1_gates 5>;
+                     gpio-controller;
+                     interrupt-controller;
+                     #address-cells = <1>;
+                     #size-cells = <0>;
+                     #gpio-cells = <3>;
+
+                     uart0_pins_a: uart0 at 0 {
+                             allwinner,pins = "PF2", "PF4";
+                             allwinner,function = "uart0";
+                             allwinner,drive = <0>;
+                             allwinner,pull = <0>;
+                     };
+
+                     i2c0_pins_a: i2c0 at 0 {
+                             allwinner,pins = "PH2", "PH3";
+                             allwinner,function = "i2c0";
+                             allwinner,drive = <0>;
+                             allwinner,pull = <0>;
+                     };
+
+                     i2c1_pins_a: i2c1 at 0 {
+                             allwinner,pins = "PH4", "PH5";
+                             allwinner,function = "i2c1";
+                             allwinner,drive = <0>;
+                             allwinner,pull = <0>;
+                     };
+             };
+
+             ahb1_rst: reset at 01c202c0 {
+                     #reset-cells = <1>;
+                     compatible = "allwinner,sun6i-a31-ahb1-reset";
+                     reg = <0x01c202c0 0xc>;
+             };
+
+             apb1_rst: reset at 01c202d0 {
+                     #reset-cells = <1>;
+                     compatible = "allwinner,sun6i-a31-clock-reset";
+                     reg = <0x01c202d0 0x4>;
+             };
+
+             apb2_rst: reset at 01c202d8 {
+                     #reset-cells = <1>;
+                     compatible = "allwinner,sun6i-a31-clock-reset";
+                     reg = <0x01c202d8 0x4>;
+             };
+
+             timer at 01c20c00 {
+                     compatible = "allwinner,sun4i-a10-timer";
+                     reg = <0x01c20c00 0xa0>;
+                     interrupts = <0 18 4>,
+                                  <0 19 4>;
+                     clocks = <&osc24M>;
+             };
+
+             wdt0: watchdog at 01c20ca0 {
+                     compatible = "allwinner,sun6i-a31-wdt";
+                     reg = <0x01c20ca0 0x20>;
+                     interrupts = <0 25 4>;
+             };
+
+             uart0: serial at 01c28000 {
+                     compatible = "snps,dw-apb-uart";
+                     reg = <0x01c28000 0x400>;
+                     interrupts = <0 0 4>;
+                     reg-shift = <2>;
+                     reg-io-width = <4>;
+                     clocks = <&apb2_gates 16>;
+                     resets = <&apb2_rst 16>;
+                     status = "disabled";
+             };
+
+             uart1: serial at 01c28400 {
+                     compatible = "snps,dw-apb-uart";
+                     reg = <0x01c28400 0x400>;
+                     interrupts = <0 1 4>;
+                     reg-shift = <2>;
+                     reg-io-width = <4>;
+                     clocks = <&apb2_gates 17>;
+                     resets = <&apb2_rst 17>;
+                     status = "disabled";
+             };
+
+             uart2: serial at 01c28800 {
+                     compatible = "snps,dw-apb-uart";
+                     reg = <0x01c28800 0x400>;
+                     interrupts = <0 2 4>;
+                     reg-shift = <2>;
+                     reg-io-width = <4>;
+                     clocks = <&apb2_gates 18>;
+                     resets = <&apb2_rst 18>;
+                     status = "disabled";
+             };
+
+             uart3: serial at 01c28c00 {
+                     compatible = "snps,dw-apb-uart";
+                     reg = <0x01c28c00 0x400>;
+                     interrupts = <0 3 4>;
+                     reg-shift = <2>;
+                     reg-io-width = <4>;
+                     clocks = <&apb2_gates 19>;
+                     resets = <&apb2_rst 19>;
+                     status = "disabled";
+             };
+
+             uart4: serial at 01c29000 {
+                     compatible = "snps,dw-apb-uart";
+                     reg = <0x01c29000 0x400>;
+                     interrupts = <0 4 4>;
+                     reg-shift = <2>;
+                     reg-io-width = <4>;
+                     clocks = <&apb2_gates 20>;
+                     resets = <&apb2_rst 20>;
+                     status = "disabled";
+             };
+
+             i2c0: i2c at 01c2ac00 {
+                     compatible = "allwinner,sun6i-a31-i2c";
+                     reg = <0x01c2ac00 0x400>;
+                     interrupts = <0 6 4>;
+                     clocks = <&apb2_gates 0>;
+                     clock-frequency = <100000>;
+                     resets = <&apb2_rst 0>;
+                     status = "disabled";
+             };
+
+             i2c1: i2c at 01c2b000 {
+                     compatible = "allwinner,sun6i-a31-i2c";
+                     reg = <0x01c2b000 0x400>;
+                     interrupts = <0 7 4>;
+                     clocks = <&apb2_gates 1>;
+                     clock-frequency = <100000>;
+                     resets = <&apb2_rst 1>;
+                     status = "disabled";
+             };
+
+             i2c2: i2c at 01c2b400 {
+                     compatible = "allwinner,sun6i-a31-i2c";
+                     reg = <0x01c2b400 0x400>;
+                     interrupts = <0 8 4>;
+                     clocks = <&apb2_gates 2>;
+                     clock-frequency = <100000>;
+                     resets = <&apb2_rst 2>;
+                     status = "disabled";
+             };
+
+             spi0: spi at 01c68000 {
+                     compatible = "allwinner,sun6i-a31-spi";
+                     reg = <0x01c68000 0x1000>;
+                     interrupts = <0 65 4>;
+                     clocks = <&ahb1_gates 20>, <&spi0_clk>;
+                     clock-names = "ahb", "mod";
+                     resets = <&ahb1_rst 20>;
+                     status = "disabled";
+             };
+
+             spi1: spi at 01c69000 {
+                     compatible = "allwinner,sun6i-a31-spi";
+                     reg = <0x01c69000 0x1000>;
+                     interrupts = <0 66 4>;
+                     clocks = <&ahb1_gates 21>, <&spi1_clk>;
+                     clock-names = "ahb", "mod";
+                     resets = <&ahb1_rst 21>;
+                     status = "disabled";
+             };
+
+             gic: interrupt-controller at 01c81000 {
+                     compatible = "arm,cortex-a7-gic", "arm,cortex-a15-gic";
+                     reg = <0x01c81000 0x1000>,
+                           <0x01c82000 0x1000>;
+                     interrupt-controller;
+                     #interrupt-cells = <3>;
+             };
+
+             nmi_intc: interrupt-controller at 01f00c0c {
+                     compatible = "allwinner,sun6i-a31-sc-nmi";
+                     interrupt-controller;
+                     #interrupt-cells = <2>;
+                     reg = <0x01f00c0c 0x38>;
+                     interrupts = <0 32 4>;
+             };
+
+             prcm at 01f01400 {
+                     compatible = "allwinner,sun8i-a23-prcm";
+                     reg = <0x01f01400 0x200>;
+
+                     ar100: ar100_clk {
+                             compatible = "fixed-factor-clock";
+                             #clock-cells = <0>;
+                             clock-div = <1>;
+                             clock-mult = <1>;
+                             clocks = <&osc24M>;
+                             clock-output-names = "ar100";
+                     };
+
+                     ahb0: ahb0_clk {
+                             compatible = "fixed-factor-clock";
+                             #clock-cells = <0>;
+                             clock-div = <1>;
+                             clock-mult = <1>;
+                             clocks = <&ar100>;
+                             clock-output-names = "ahb0";
+                     };
+
+                     apb0: apb0_clk {
+                             compatible = "allwinner,sun8i-a23-apb0-clk";
+                             #clock-cells = <0>;
+                             clocks = <&ahb0>;
+                             clock-output-names = "apb0";
+                     };
+
+                     apb0_gates: apb0_gates_clk {
+                             compatible = "allwinner,sun6i-a31-apb0-gates-clk";
+                             #clock-cells = <1>;
+                             clocks = <&apb0>;
+                             clock-indices = <0>, <2>, <3>, <4>, <6>;
+                             clock-output-names = "apb0_pio", "apb0_timer",
+                                             "apb0_rsb", "apb0_uart",
+                                             "apb0_i2c";
+                     };
+
+                     apb0_rst: apb0_rst {
+                             compatible = "allwinner,sun6i-a31-clock-reset";
+                             #reset-cells = <1>;
+                     };
+             };
+
+             cpucfg at 01f01c00 {
+                     compatible = "allwinner,sun8i-a23-cpuconfig";
+                     reg = <0x01f01c00 0x300>;
+             };
+
+             r_uart: serial at 01f02800 {
+                     compatible = "snps,dw-apb-uart";
+                     reg = <0x01f02800 0x400>;
+                     interrupts = <0 38 4>;
+                     reg-shift = <2>;
+                     reg-io-width = <4>;
+                     clocks = <&apb0_gates 4>;
+                     resets = <&apb0_rst 4>;
+                     status = "disabled";
+             };
+
+             r_pio: pinctrl at 01f02c00 {
+                     compatible = "allwinner,sun8i-a23-r-pinctrl";
+                     reg = <0x01f02c00 0x400>;
+                     interrupts = <0 45 4>;
+                     clocks = <&apb0_gates 0>;
+                     resets = <&apb0_rst 0>;
+                     gpio-controller;
+                     interrupt-controller;
+                     #address-cells = <1>;
+                     #size-cells = <0>;
+                     #gpio-cells = <3>;
+
+                     r_uart_pins_a: r_uart at 0 {
+                             allwinner,pins = "PL2", "PL3";
+                             allwinner,function = "s_uart";
+                             allwinner,drive = <0>;
+                             allwinner,pull = <0>;
+                     };
+
+             };
+     };
+};
Thanks,
Maxime
Thanks for the review.
ChenYu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help