Hi,

On Fri, May 23, 2014 at 9:09 PM, Emilio L?pez [off-list ref] wrote:

Hi,

El 23/05/14 04:51, Chen-Yu Tsai escribi?:

quoted

The N factor for PLL6 counts from 1 to 32, as specified in the A23
manual, and shown in Allwinner's original code.

Are you sure about this? The A23 manual I'm looking at has a 5-bit field (so
0-31) on 12:8, and the examples count from 0 (eg Factor=0 N=1 ... Factor=31
N=32).

From the A23 manual:

Factor = 0, N = 1
Factor = 1, N = 2
Factor = 2, N = 3
 and so on

From the A20 manual:

Factor = 0, N = 0
Factor = 1, N = 1
Factor = 2, N = 2

The "N factor" I referred to in my commit message is the N used in the
calculation,
not what is stored in the bit field.

Hope this makes it clear. :)

Cheers
ChenYu