[PATCH 01/22] serial: 8250_dw: Add optional reset control support
From: arnd@arndb.de (Arnd Bergmann)
Date: 2014-05-23 08:20:05
Also in:
linux-devicetree, linux-serial, lkml
On Friday 23 May 2014 15:51:04 Chen-Yu Tsai wrote:
quoted hunk ↗ jump to hunk
p->regshift = val; + data->rst = devm_reset_control_get_optional(p->dev, NULL); + /* clock got configured through clk api, all done */ if (p->uartclk) return 0;@@ -362,6 +366,9 @@ static int dw8250_probe(struct platform_device *pdev) return -ENODEV; } + if (!IS_ERR_OR_NULL(data->rst)) + reset_control_deassert(data->rst); +
You should basically never use IS_ERR_OR_NULL(). devm_reset_control_get_optional() doesn't return NULL, so IS_ERR() should be safe. Alternatively, change the code above to set data->rst to NULL if there is no reset line or error out if you get a different error (e.g. EPROBE_DEFER). Arnd