[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file

[PATCH 00/12] PCI:Add SPEAr13xx PCie support · Mohit Kumar <hidden> · 2013-12-11
[PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr · Mohit Kumar <hidden> · 2013-12-11
Re: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr · Rajeev kumar <hidden> · 2013-12-11
Re: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr · Rajeev kumar <hidden> · 2013-12-11
Re: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr · Jingoo Han <hidden> · 2013-12-12
Re: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr · Rajeev kumar <hidden> · 2013-12-12
Re: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr · Chen-Yu Tsai <hidden> · 2013-12-12
RE: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr · Mohit KUMAR DCG <hidden> · 2013-12-12
[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file · Mohit Kumar <hidden> · 2013-12-11
[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file · arnd@arndb.de (Arnd Bergmann) · 2013-12-11
[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file · Mohit KUMAR DCG <hidden> · 2013-12-13
[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file · arnd@arndb.de (Arnd Bergmann) · 2013-12-14
[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file · Mohit KUMAR DCG <hidden> · 2014-01-16
[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file · Pratyush Anand <hidden> · 2014-01-16
[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file · arnd@arndb.de (Arnd Bergmann) · 2014-01-16
[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file · Pratyush Anand <hidden> · 2014-01-16
[PATCH 03/12] SPEAr13xx: Add SPEAr1310 PCIe register definitions · Mohit Kumar <hidden> · 2013-12-11
[PATCH 03/12] SPEAr13xx: Add SPEAr1310 PCIe register definitions · arnd@arndb.de (Arnd Bergmann) · 2013-12-11
[PATCH 04/12] SPEAr13xx: Fix static mapping table · Mohit Kumar <hidden> · 2013-12-11
[PATCH 05/12] clk: SPEAr13xx: Fix pcie clock name · Mohit Kumar <hidden> · 2013-12-11
[PATCH 05/12] clk: SPEAr13xx: Fix pcie clock name · arnd@arndb.de (Arnd Bergmann) · 2013-12-11
[PATCH 05/12] clk: SPEAr13xx: Fix pcie clock name · Mohit KUMAR DCG <hidden> · 2013-12-12
[PATCH 05/12] clk: SPEAr13xx: Fix pcie clock name · arnd@arndb.de (Arnd Bergmann) · 2013-12-12
[PATCH 06/12] pcie: designware: Move register definition to the header file · Mohit Kumar <hidden> · 2013-12-11
[PATCH 06/12] pcie: designware: Move register definition to the header file · Jagan Teki <hidden> · 2013-12-11
[PATCH 06/12] pcie: designware: Move register definition to the header file · Mohit KUMAR DCG <hidden> · 2013-12-11
[PATCH 06/12] pcie: designware: Move register definition to the header file · Jagan Teki <hidden> · 2013-12-11
[PATCH 06/12] pcie: designware: Move register definition to the header file · arnd@arndb.de (Arnd Bergmann) · 2013-12-11
[PATCH 06/12] pcie: designware: Move register definition to the header file · Jingoo Han <hidden> · 2013-12-11
[PATCH 06/12] pcie: designware: Move register definition to the header file · Mohit KUMAR DCG <hidden> · 2013-12-12
[PATCH 07/12] pcie: designware: add dw_pcie prefix before cfg_read/write · Mohit Kumar <hidden> · 2013-12-11
[PATCH 07/12] pcie: designware: add dw_pcie prefix before cfg_read/write · Jagan Teki <hidden> · 2013-12-11
[PATCH 07/12] pcie: designware: add dw_pcie prefix before cfg_read/write · Jingoo Han <hidden> · 2013-12-12
[PATCH 07/12] pcie: designware: add dw_pcie prefix before cfg_read/write · Jingoo Han <hidden> · 2013-12-12
[PATCH 07/12] pcie: designware: add dw_pcie prefix before cfg_read/write · bhelgaas@google.com (Bjorn Helgaas) · 2013-12-20
[PATCH 08/12] pcie: designware: Fix IO transfers · Mohit Kumar <hidden> · 2013-12-11
[PATCH 08/12] pcie: designware: Fix IO transfers · marex@denx.de (Marek Vasut) · 2013-12-11
[PATCH 08/12] pcie: designware: Fix IO transfers · Jagan Teki <hidden> · 2013-12-11
[PATCH 08/12] pcie: designware: Fix IO transfers · Jingoo Han <hidden> · 2013-12-12
[PATCH 08/12] pcie: designware: Fix IO transfers · Pratyush Anand <hidden> · 2013-12-20
[PATCH 08/12] pcie: designware: Fix IO transfers · arnd@arndb.de (Arnd Bergmann) · 2013-12-11
[PATCH 08/12] pcie: designware: Fix IO transfers · Jingoo Han <hidden> · 2013-12-11
[PATCH 08/12] pcie: designware: Fix IO transfers · bhelgaas@google.com (Bjorn Helgaas) · 2013-12-20
[PATCH 09/12] pcie: SPEAr13xx: Add designware pcie support · Mohit Kumar <hidden> · 2013-12-11
[PATCH 09/12] pcie: SPEAr13xx: Add designware pcie support · arnd@arndb.de (Arnd Bergmann) · 2013-12-11
[PATCH 09/12] pcie: SPEAr13xx: Add designware pcie support · Mohit KUMAR DCG <hidden> · 2013-12-13
[PATCH 09/12] pcie: SPEAr13xx: Add designware pcie support · Jingoo Han <hidden> · 2013-12-13
[PATCH 09/12] pcie: SPEAr13xx: Add designware pcie support · arnd@arndb.de (Arnd Bergmann) · 2013-12-14
[PATCH 10/12] SPEAr13xx: defconfig: Update · Mohit Kumar <hidden> · 2013-12-11
[PATCH 10/12] SPEAr13xx: defconfig: Update · Rajeev kumar <hidden> · 2013-12-11
[PATCH 10/12] SPEAr13xx: defconfig: Update · Mohit KUMAR DCG <hidden> · 2013-12-12
[PATCH 11/12] MAINTAINERS: Add ST SPEAr13xx PCIe driver maintainer · Mohit Kumar <hidden> · 2013-12-11
[PATCH 11/12] MAINTAINERS: Add ST SPEAr13xx PCIe driver maintainer · Jingoo Han <hidden> · 2013-12-12
[PATCH 12/12] MAINTAINERS: Add Synopsis Designware PCIe driver maintainer · Mohit Kumar <hidden> · 2013-12-11

STALE4548d

From: Mohit KUMAR DCG <hidden>
Date: 2013-12-13 04:18:35
Also in: linux-pci

Hello Arnd,

-----Original Message-----
From: Arnd Bergmann [mailto:arnd at arndb.de]
Sent: Thursday, December 12, 2013 4:18 AM
To: linux-arm-kernel at lists.infradead.org
Cc: Mohit KUMAR DCG; linux-pci at vger.kernel.org; Pratyush ANAND; spear-
devel; Viresh Kumar
Subject: Re: [PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to
header file

On Wednesday 11 December 2013, Mohit Kumar wrote:

quoted

From: Pratyush Anand <redacted>

Move SPEAr1340 definitions to header files so that theese can be used
by other code too.

This looks like a regression, we intentionally made them private and they
should be moved into a proper driver instead of being globally visible.

quoted

diff --git a/arch/arm/mach-spear/include/mach/spear.h

b/arch/arm/mach-spear/include/mach/spear.h
index 5cdc53d..4526f75 100644

--- a/arch/arm/mach-spear/include/mach/spear.h
+++ b/arch/arm/mach-spear/include/mach/spear.h

@@ -86,6 +86,61 @@
 /* Debug uart for linux, will be used for debug and uncompress messages

*/

quoted

 #define SPEAR_DBG_UART_BASE			UART_BASE

+/* PCIe/SATA Base addresses */
+#define SPEAR1340_SATA_BASE			UL(0xB1000000)
+#define SPEAR1340_PCIE_BASE			UL(0xB1000000)

These should be in DT only.

quoted

+/* Power Management Registers */
+#define SPEAR1340_PCM_CFG			(VA_MISC_BASE +

0x100)

quoted

+#define SPEAR1340_PCM_WKUP_CFG

	(VA_MISC_BASE + 0x104)

quoted

+#define SPEAR1340_SWITCH_CTR			(VA_MISC_BASE +

0x108)

quoted

+
+#define SPEAR1340_PERIP1_SW_RST

	(VA_MISC_BASE + 0x318)

quoted

+#define SPEAR1340_PERIP2_SW_RST

	(VA_MISC_BASE + 0x31C)

quoted

+#define SPEAR1340_PERIP3_SW_RST

	(VA_MISC_BASE + 0x320)
	
The RST bits should probably go into a drivers/reset driver. Not sure what the
other registers do, but I'm sure we can find a driver for these too, possibly
they should be part of the PHY driver?

-  Perhaps if we implement phy and reset driver then we may not require to move these definitions and
it will address most of your comments on SPEar13xx pcie driver. I am understanding and working on this.l 

Regards
Mohit

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help