[PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr
From: Jingoo Han <hidden>
Date: 2013-12-12 00:39:07
Also in:
linux-devicetree, linux-pci
From: Jingoo Han <hidden>
Date: 2013-12-12 00:39:07
Also in:
linux-devicetree, linux-pci
On Wednesday, December 11, 2013 8:09 PM, Rajeev kumar wrote:
On 12/11/2013 3:08 PM, Mohit KUMAR wrote:quoted
DT field name for the phy address changed since kernel 3.10. Set the snps,phy-addr to 0xffffffff so that the driver probes for the phy. Signed-off-by: Mohit Kumar<redacted> Cc: Pratyush Anand<redacted> Cc: Viresh Kumar<redacted> Cc: spear-devel at list.st.com Cc: linux-arm-kernel at lists.infradead.org Cc: devicetree at vger.kernel.org --- arch/arm/boot/dts/spear13xx.dtsi | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)diff --git a/arch/arm/boot/dts/spear13xx.dtsi b/arch/arm/boot/dts/spear13xx.dtsi index 4382547..3518803 100644 --- a/arch/arm/boot/dts/spear13xx.dtsi +++ b/arch/arm/boot/dts/spear13xx.dtsi@@ -155,6 +155,7 @@ gmac0: eth at e2000000 { compatible = "st,spear600-gmac"; + snps,phy-addr =<0xffffffff>;Don't you think it should be st,phy-addr =<0xffffffff>, as the manufacturer is 'st' as the compatible suggest
Hi Rajeev Kumar, According to the Documentation, it guides to use 'snps' prefix. In my humble opinion, 'gmac' is a Synopsys based IP. Thus, if 'snps,phy-addr' is not ST specific, 'snps' prefix can be used. ./Documentation/devicetree/bindings/net/stmmac.txt - snps,phy-addr phy address to connect to. Best regards, Jingoo Han