[PATCH 06/12] pcie: designware: Move register definition to the header file

[PATCH 00/12] PCI:Add SPEAr13xx PCie support · Mohit Kumar <hidden> · 2013-12-11
[PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr · Mohit Kumar <hidden> · 2013-12-11
Re: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr · Rajeev kumar <hidden> · 2013-12-11
Re: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr · Rajeev kumar <hidden> · 2013-12-11
Re: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr · Jingoo Han <hidden> · 2013-12-12
Re: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr · Rajeev kumar <hidden> · 2013-12-12
Re: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr · Chen-Yu Tsai <hidden> · 2013-12-12
RE: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr · Mohit KUMAR DCG <hidden> · 2013-12-12
[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file · Mohit Kumar <hidden> · 2013-12-11
[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file · arnd@arndb.de (Arnd Bergmann) · 2013-12-11
[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file · Mohit KUMAR DCG <hidden> · 2013-12-13
[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file · arnd@arndb.de (Arnd Bergmann) · 2013-12-14
[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file · Mohit KUMAR DCG <hidden> · 2014-01-16
[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file · Pratyush Anand <hidden> · 2014-01-16
[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file · arnd@arndb.de (Arnd Bergmann) · 2014-01-16
[PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file · Pratyush Anand <hidden> · 2014-01-16
[PATCH 03/12] SPEAr13xx: Add SPEAr1310 PCIe register definitions · Mohit Kumar <hidden> · 2013-12-11
[PATCH 03/12] SPEAr13xx: Add SPEAr1310 PCIe register definitions · arnd@arndb.de (Arnd Bergmann) · 2013-12-11
[PATCH 04/12] SPEAr13xx: Fix static mapping table · Mohit Kumar <hidden> · 2013-12-11
[PATCH 05/12] clk: SPEAr13xx: Fix pcie clock name · Mohit Kumar <hidden> · 2013-12-11
[PATCH 05/12] clk: SPEAr13xx: Fix pcie clock name · arnd@arndb.de (Arnd Bergmann) · 2013-12-11
[PATCH 05/12] clk: SPEAr13xx: Fix pcie clock name · Mohit KUMAR DCG <hidden> · 2013-12-12
[PATCH 05/12] clk: SPEAr13xx: Fix pcie clock name · arnd@arndb.de (Arnd Bergmann) · 2013-12-12
[PATCH 06/12] pcie: designware: Move register definition to the header file · Mohit Kumar <hidden> · 2013-12-11
[PATCH 06/12] pcie: designware: Move register definition to the header file · Jagan Teki <hidden> · 2013-12-11
[PATCH 06/12] pcie: designware: Move register definition to the header file · Mohit KUMAR DCG <hidden> · 2013-12-11
[PATCH 06/12] pcie: designware: Move register definition to the header file · Jagan Teki <hidden> · 2013-12-11
[PATCH 06/12] pcie: designware: Move register definition to the header file · arnd@arndb.de (Arnd Bergmann) · 2013-12-11
[PATCH 06/12] pcie: designware: Move register definition to the header file · Jingoo Han <hidden> · 2013-12-11
[PATCH 06/12] pcie: designware: Move register definition to the header file · Mohit KUMAR DCG <hidden> · 2013-12-12
[PATCH 07/12] pcie: designware: add dw_pcie prefix before cfg_read/write · Mohit Kumar <hidden> · 2013-12-11
[PATCH 07/12] pcie: designware: add dw_pcie prefix before cfg_read/write · Jagan Teki <hidden> · 2013-12-11
[PATCH 07/12] pcie: designware: add dw_pcie prefix before cfg_read/write · Jingoo Han <hidden> · 2013-12-12
[PATCH 07/12] pcie: designware: add dw_pcie prefix before cfg_read/write · Jingoo Han <hidden> · 2013-12-12
[PATCH 07/12] pcie: designware: add dw_pcie prefix before cfg_read/write · bhelgaas@google.com (Bjorn Helgaas) · 2013-12-20
[PATCH 08/12] pcie: designware: Fix IO transfers · Mohit Kumar <hidden> · 2013-12-11
[PATCH 08/12] pcie: designware: Fix IO transfers · marex@denx.de (Marek Vasut) · 2013-12-11
[PATCH 08/12] pcie: designware: Fix IO transfers · Jagan Teki <hidden> · 2013-12-11
[PATCH 08/12] pcie: designware: Fix IO transfers · Jingoo Han <hidden> · 2013-12-12
[PATCH 08/12] pcie: designware: Fix IO transfers · Pratyush Anand <hidden> · 2013-12-20
[PATCH 08/12] pcie: designware: Fix IO transfers · arnd@arndb.de (Arnd Bergmann) · 2013-12-11
[PATCH 08/12] pcie: designware: Fix IO transfers · Jingoo Han <hidden> · 2013-12-11
[PATCH 08/12] pcie: designware: Fix IO transfers · bhelgaas@google.com (Bjorn Helgaas) · 2013-12-20
[PATCH 09/12] pcie: SPEAr13xx: Add designware pcie support · Mohit Kumar <hidden> · 2013-12-11
[PATCH 09/12] pcie: SPEAr13xx: Add designware pcie support · arnd@arndb.de (Arnd Bergmann) · 2013-12-11
[PATCH 09/12] pcie: SPEAr13xx: Add designware pcie support · Mohit KUMAR DCG <hidden> · 2013-12-13
[PATCH 09/12] pcie: SPEAr13xx: Add designware pcie support · Jingoo Han <hidden> · 2013-12-13
[PATCH 09/12] pcie: SPEAr13xx: Add designware pcie support · arnd@arndb.de (Arnd Bergmann) · 2013-12-14
[PATCH 10/12] SPEAr13xx: defconfig: Update · Mohit Kumar <hidden> · 2013-12-11
[PATCH 10/12] SPEAr13xx: defconfig: Update · Rajeev kumar <hidden> · 2013-12-11
[PATCH 10/12] SPEAr13xx: defconfig: Update · Mohit KUMAR DCG <hidden> · 2013-12-12
[PATCH 11/12] MAINTAINERS: Add ST SPEAr13xx PCIe driver maintainer · Mohit Kumar <hidden> · 2013-12-11
[PATCH 11/12] MAINTAINERS: Add ST SPEAr13xx PCIe driver maintainer · Jingoo Han <hidden> · 2013-12-12
[PATCH 12/12] MAINTAINERS: Add Synopsis Designware PCIe driver maintainer · Mohit Kumar <hidden> · 2013-12-11

STALE4544d

From: Jingoo Han <hidden>
Date: 2013-12-11 22:48:56
Also in: linux-pci

On Thursday, December 12, 2013 6:32 AM, Arnd Bergmann wrote:

On Wednesday 11 December 2013, Mohit KUMAR DCG wrote:

quoted

Seems like none were using these headers except pcie-designware.c - if ie
the case better to place it same place as before.

- We have include these and used few like ' PCIE_LINK_WIDTH_SPEED_CONTROL '  for SPEAr13xx platform,
so move these to the separate header  file.

I think it's better not to touch any of the registers from a platform-specific
driver. Better make a high-level function in the common code that the
spear driver can call to change this register.

I also agree with Arnd's opinion.

Best regards,
Jingoo Han

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help