* Mohammed, Afzal [off-list ref] [120614 05:00]:

Hi Tony,

On Thu, Jun 14, 2012 at 17:22:08, Tony Lindgren wrote:

quoted

* Mohammed, Afzal [off-list ref] [120614 03:43]:

quoted

+       t.clk_activation = fclk_offset_ns;
+

This too should be fclk_offset, not fclk_offset_ns.

As gpmc_cs_set_timing convert it to ticks from ns,
shouldn't we put it in ns ? 

Hmm I see, something's wrong though.. Some of these we really
want to specify as ticks instead of ns. Your patch was using
1 tick value as 1 ns value, which won't work. When I changed
it back to what I thought was ticks, it just happened to work
probably because of rounding. That's probably the reason why
some of these have been set directly with gpmc_cs_write_reg
as that sets tick values directly.

It seems that we need to still allow both ns and tick values.

Regards,

Tony