Thread (50 messages) 50 messages, 3 authors, 2012-06-15
STALE5116d

[PATCH 3/3] ARM: OMAP2+: gpmc: handle additional timings

From: tony@atomide.com (Tony Lindgren)
Date: 2012-06-14 11:52:08
Also in: linux-omap

* Mohammed, Afzal [off-list ref] [120614 03:43]:
quoted hunk ↗ jump to hunk
Hi Tony,

On Thu, Jun 14, 2012 at 15:49:02, Tony Lindgren wrote:
quoted
Well I took a look at the values, and it seems the only difference is the
static GPMC_CONFIG1_CLKACTIVATIONTIME(1) that your patch now overwrites 0.
It seems change below should be part of $subject.

Please let me know your comments

Regards
Afzal
diff --git a/arch/arm/mach-omap2/gpmc-onenand.c b/arch/arm/mach-omap2/gpmc-onenand.c
index fd4c48d..938896c 100644
--- a/arch/arm/mach-omap2/gpmc-onenand.c
+++ b/arch/arm/mach-omap2/gpmc-onenand.c
@@ -321,6 +321,8 @@ static int omap2_onenand_set_sync_mode(struct omap_onenand_platform_data *cfg,
        t.rd_cycle = gpmc_ticks_to_ns(fclk_offset + (latency + 1) * div +
                     ticks_cez);

+       t.clk_activation = fclk_offset_ns;
+
This too should be fclk_offset, not fclk_offset_ns.

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help