Thread (138 messages) flat view 138 messages, 14 authors, 2012-05-24
STALE5186d

[PATCH] arm: Add basic support for new Marvell Armada SoC family

From: Jason Cooper <hidden>
Date: 2012-05-21 01:30:50

On Sun, May 20, 2012 at 12:10:25PM +0100, Russell King - ARM Linux wrote:
On Sun, May 20, 2012 at 10:58:37AM +0000, Arnd Bergmann wrote:
quoted
On Sunday 20 May 2012, Russell King - ARM Linux wrote:
quoted
And try to avoid putting anything in the include/mach/ directory which
isn't needed by any code outside of arch/arm/{plat,mach}-* directory.

In other words, headers needed only for code in arch/arm/plat-mvvebu/
should be in that very same directory.
Ok, so let me make sure I got it all right:

* all *.c files that are used for multiple boards go to plat-mvebu
* all *-setup.c files go to mach-mvebu
* only headers that are used outside of {mach,plat}-mvebug go to
  plat-mvebu/include/mach
plat-mvebu/include/plat ?
quoted
* headers used to inteface between the first two go to
  plat-mvebu/include/plat (?)
plat-mvebu/include ?
That sounds reasonable.  The only eyebrow raising thing is having an
include/mach inside a plat-* directory... that seems an odd way to do
things as mach/ includes normally come from the mach-* directory.

So I wonder whether Nicolas' idea of "dt-only stuff in arch/arm/plat-*"
is the right idea.  It just makes plat-* the same as a mach-* but with
a different name, whereas it is _supposed_ to be for stuff shared
between a bunch of mach-* directories.
In an ideal (dt) world, plat-*/ would hold all the dt source files, and
arch/arm/boot/dts/ would become the new mach-*/.  mach-*/ is kept around
for the few legacy, unconverted boards.

Or, am I barking up the wrong tree?

thx,

Jason.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help