Thread (138 messages) flat view 138 messages, 14 authors, 2012-05-24
STALE5186d

[PATCH 6/8] arm: mach-armada: add support for Armada XP board with device tree

From: Rob Herring <hidden>
Date: 2012-05-15 14:53:55

On 05/15/2012 09:25 AM, Arnd Bergmann wrote:
On Tuesday 15 May 2012, Thomas Petazzoni wrote:
quoted
Le Tue, 15 May 2012 14:53:45 +0100,
Ben Dooks [off-list ref] a ?crit :
quoted
Since the two board support files are identical, except for the names
they print, I'd say this is the job of one file. It can always be
split later.
The initial motivation for keeping two files here is that the two SoC
have a different number of PCIe memory areas, and those areas are
typically mapped in ->map_io(). However:

 * Maybe those mappings can be done using a normal ioremap() rather
   than in ->map_io(), according to DT informations (but most other ARM
   SoC support at the moment seem to do PCI mappings using static
   mappings in ->map_io)
I'm pretty sure we can use ioremap for new PCI implementations now.
Also, you can scan the device tree in map_io() if necesary, to see which
PCIe ports are enabled.
For the i/o windows, they should be static because we want a fixed
virtual address across platforms. 0xfef00000 is the planned address.
Memory windows should be ioremap.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help