Thread (138 messages) flat view 138 messages, 14 authors, 2012-05-24
STALE5188d

[PATCH] arm: Add basic support for new Marvell Armada SoC family

From: nico@fluxnic.net (Nicolas Pitre)
Date: 2012-05-16 16:49:07

On Wed, 16 May 2012, Arnd Bergmann wrote:
On Wednesday 16 May 2012, Lior Amsalem wrote:
quoted
quoted
Thanks for the list, very helpful!

So do you think it makes sense to put all of these into mach-orion?
Well, Orion is old and seems like not the best name for a directory to include 
all the new platforms.
We are discussing it internally as well and I'll update with our suggestion.
The name has the advantage that we have a bunch of drivers using it already:

arch/arm/plat-orion/gpio.c
arch/arm/plat-orion/irq.c
arch/arm/plat-orion/mpp.c
arch/arm/plat-orion/pcie.c
arch/arm/plat-orion/time.c
drivers/mtd/nand/orion_nand.c
drivers/spi/spi-orion.c
drivers/usb/host/ehci-orion.c
drivers/watchdog/orion_wdt.c

AFAICT, those are shared between most of those socs, and I would not want
to change the code in them to the new name.
Why not?  Module aliases can be used if that is a concern.
If we change the directory
name to something completely different, it no longer matches the driver
names.
I wouldn't consider this as a major concern.  For example, the ethernet 
driver that all those SOCs use is not called "orion".


Nicolas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help