[PATCH 6/8] arm: mach-armada: add support for Armada XP board with device tree

On 15/05/12 15:25, Arnd Bergmann wrote:

On Tuesday 15 May 2012, Thomas Petazzoni wrote:

quoted

Le Tue, 15 May 2012 14:53:45 +0100,
Ben Dooks[off-list ref]  a ?crit :

quoted

Since the two board support files are identical, except for the names
they print, I'd say this is the job of one file. It can always be
split later.

The initial motivation for keeping two files here is that the two SoC
have a different number of PCIe memory areas, and those areas are
typically mapped in ->map_io(). However:

  * Maybe those mappings can be done using a normal ioremap() rather
    than in ->map_io(), according to DT informations (but most other ARM
    SoC support at the moment seem to do PCI mappings using static
    mappings in ->map_io)

I'm pretty sure we can use ioremap for new PCI implementations now.
Also, you can scan the device tree in map_io() if necesary, to see which
PCIe ports are enabled.

To be honest, if you need it, then it'd be a good idea to fix anyway.

And at worst you can always construct map_desc entries on the stack
and call iotable_init()

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius