On Fri, Jul 29, 2011 at 05:46:39PM +0530, Koul, Vinod wrote:

On Fri, 2011-07-29 at 16:19 +0530, Viresh Kumar wrote:

quoted

+	/* check & clear - ERR & TC interrupts */
+	err = readl(pl08x->base + PL080_ERR_STATUS);
+	if (err) {
+		dev_err(&pl08x->adev->dev, "%s error interrupt, register value"
+				"0x%08x\n", __func__, err);

again this looks convoluted, and the stuff is quotes can be in single
line :)

And it shows the danger of wrapping quoted strings.  This will print
the following message:

...: pl08x_irq error interrupt, register value0xNNNNNNNN

So it may want a space between 'value' and '0x%08x' - and it may want a
':' after '%s' too.