[PATCH 02/18] dmaengine/amba-pl08x: Resolve formatting issues
From: Russell King - ARM Linux <hidden>
Date: 2011-07-29 11:00:45
Also in:
lkml
On Fri, Jul 29, 2011 at 04:19:12PM +0530, Viresh Kumar wrote:
There were few formatting related issues in code. This patch fixes them. Fixes include: - Remove extra blank lines and spaces
A double space after a full-stop is standard practice for many people. Please don't reformat that.
quoted hunk ↗ jump to hunk
@@ -284,7 +284,7 @@ static void pl08x_terminate_phy_chan(struct pl08x_driver_data *pl08x, u32 val = readl(ch->base + PL080_CH_CONFIG); val &= ~(PL080_CONFIG_ENABLE | PL080_CONFIG_ERR_IRQ_MASK | - PL080_CONFIG_TC_IRQ_MASK); + PL080_CONFIG_TC_IRQ_MASK);
This looks worse than the original.
quoted hunk ↗ jump to hunk
writel(val, ch->base + PL080_CH_CONFIG);@@ -380,7 +380,7 @@ static u32 pl08x_getbytes_chan(struct pl08x_dma_chan *plchan) */ static struct pl08x_phy_chan * pl08x_get_phy_channel(struct pl08x_driver_data *pl08x, - struct pl08x_dma_chan *virt_chan) + struct pl08x_dma_chan *virt_chan)
Ditto.
quoted hunk ↗ jump to hunk
{ struct pl08x_phy_chan *ch = NULL; unsigned long flags;@@ -445,7 +445,7 @@ static inline unsigned int pl08x_get_bytes_for_cctl(unsigned int coded) } static inline u32 pl08x_cctl_bits(u32 cctl, u8 srcwidth, u8 dstwidth, - size_t tsize) + size_t tsize)
Ditto. And many more of that.
ret = dma_async_device_register(&pl08x->memcpy);
if (ret) {
- dev_warn(&pl08x->adev->dev,
- "%s failed to register memcpy as an async device - %d\n",
- __func__, ret);
+ dev_warn(&pl08x->adev->dev, "%s failed to register memcpy as an"
+ " async device - %d\n", __func__, ret);Definitely not acceptable. Ignore warnings about wrapping 80 columns for kernel messages.