[PATCH 15/18] dmaengine/amba-pl08x: Pass flow controller information with slave channel data
From: Russell King - ARM Linux <hidden>
Date: 2011-07-29 11:11:08
Also in:
lkml
From: Russell King - ARM Linux <hidden>
Date: 2011-07-29 11:11:08
Also in:
lkml
Apart from my initial question in this thread... On Fri, Jul 29, 2011 at 04:19:25PM +0530, Viresh Kumar wrote:
+ if (plchan->cd->fc) + tmp = plchan->cd->fc; + else + tmp = (direction == DMA_TO_DEVICE) ? PL080_FLOW_MEM2PER : + PL080_FLOW_PER2MEM; + + txd->ccfg |= tmp << PL080_CONFIG_FLOW_CONTROL_SHIFT; +
Please, no, don't go back to encoding the flow mask into the platform data. Instead use 'fc' as an indication of who should be the flow controller, and hav ethis select the flow control based on both 'fc' and the direction.