On 07/29/2011 04:30 PM, Russell King - ARM Linux wrote:

On Fri, Jul 29, 2011 at 04:19:12PM +0530, Viresh Kumar wrote:

quoted

- Remove extra blank lines and spaces

A double space after a full-stop is standard practice for many people.
Please don't reformat that.

Ok. I didn't knew it.

quoted

@@ -284,7 +284,7 @@ static void pl08x_terminate_phy_chan(struct pl08x_driver_data *pl08x,
 	u32 val = readl(ch->base + PL080_CH_CONFIG);
 
 	val &= ~(PL080_CONFIG_ENABLE | PL080_CONFIG_ERR_IRQ_MASK |
-	         PL080_CONFIG_TC_IRQ_MASK);
+			PL080_CONFIG_TC_IRQ_MASK);

This looks worse than the original.

And many more of that.

Ok. Should i leave tabs and spaces mixed or just delete one tab in my change.

quoted

 	ret = dma_async_device_register(&pl08x->memcpy);
 	if (ret) {
-		dev_warn(&pl08x->adev->dev,
-			"%s failed to register memcpy as an async device - %d\n",
-			__func__, ret);
+		dev_warn(&pl08x->adev->dev, "%s failed to register memcpy as an"
+				" async device - %d\n", __func__, ret);

Definitely not acceptable.  Ignore warnings about wrapping 80 columns for
kernel messages.

Ok.

-- 
viresh