Thread (112 messages) flat view 112 messages, 5 authors, 17h ago

Re: [PATCH GSoC v6 06/10] transport: drop remote object-info fields from transport struct

From: Chandra Pratap <hidden>
Date: 2026-08-08 19:00:05

On Sat, 8 Aug 2026 at 21:51, Junio C Hamano [off-list ref] wrote:
Pablo Sabater [off-list ref] writes:
quoted
Rather than take these as function parameters, we take only the
transport object, and expect the caller to have placed the other two
into special fields in the transport struct. But this doesn't make much
sense. The set of oids and results are really only valid for one
request. There is no reason the transport would need to hang on to them
outside of the single function call.
Thanks for injecting some sanity into the mix.

With this fixed, are we happy with the entire series by now?
Just went through the series and everything looks good to me, but I've had
the same opinion for the last couple of iterations as well.

Thanks,
Chandra.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help