Thread (81 messages) flat view 81 messages, 5 authors, 1d ago

Re: [PATCH GSoC v3 3/8] fetch-object-info: pass arguments directly instead of a struct

From: Junio C Hamano <hidden>
Date: 2026-08-03 18:23:59

Pablo Sabater [off-list ref] writes:
struct object_info_args groups three pointers that already live in the
transport and are given to fetch_object_info().
Grouping them into a struct reduces the number of parameters, but it
suggests that fetch_object_info() uses all three of them.

Drop the struct and pass those parameters directly to
fetch_object_info() and send_object_info_request(). This should have no
change in behavior.

Helped-by: Jeff King [off-list ref]
Helped-by: Junio C Hamano [off-list ref]
Mentored-by: Karthik Nayak [off-list ref]
Mentored-by: Chandra Pratap [off-list ref]
Signed-off-by: Pablo Sabater <redacted>
---
 fetch-object-info.c | 53 +++++++++++++++++++++++++++++++----------------------
 fetch-object-info.h | 17 ++++++++---------
 transport.c         | 11 +++++------
 3 files changed, 44 insertions(+), 37 deletions(-)
This has lots of changes but quite straight-forward.  We lose the
intermediate wrapper "object_info_args" and the uses of the members
of that wrapper structure are updated with direct reference to a
variable.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help